Bug 154483

Summary: Do not require UDate in LocaleICU with !ENABLE_DATE_AND_TIME_INPUT_TYPES
Product: WebKit Reporter: Olivier Blin <olivier.blin>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, commit-queue, darin, ewmailing, mcatanzaro, zan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Olivier Blin
Reported 2016-02-19 17:07:13 PST
initializeShortDateFormat(), dateFormat(), m_shortDateFormat and m_didCreateShortDateFormat should be moved under flag, since they are only used by code under the ENABLE_DATE_AND_TIME_INPUT_TYPES flag. This helps to build with a light ICU that does not provide UDate features (with UCONFIG_NO_FORMATTING).
Attachments
Patch (5.29 KB, patch)
2016-02-19 17:09 PST, Olivier Blin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Olivier Blin
Comment 1 2016-02-19 17:09:10 PST
Created attachment 271829 [details] Patch
Michael Catanzaro
Comment 2 2016-02-20 07:53:38 PST
Comment on attachment 271829 [details] Patch I guess it's right; I looked in bug #101007 for some explanation of why short data format was not behind this flag, but couldn't find any justification for this.
WebKit Commit Bot
Comment 3 2016-02-20 08:42:21 PST
Comment on attachment 271829 [details] Patch Clearing flags on attachment: 271829 Committed r196861: <http://trac.webkit.org/changeset/196861>
WebKit Commit Bot
Comment 4 2016-02-20 08:42:26 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.