Bug 154442

Summary: Add isJSString(JSCell*) variant to avoid Cell->JSValue->Cell conversion
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: JavaScriptCoreAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ggaren, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2016-02-18 23:46:54 PST
Unlike isJSArray and isJSNonFinalObject functions which have JSCell and JSValue variants, the isJSString helper only had a JSValue variant. Add the cell variant to avoid possible extra unnecessary conversions. The JSC::JSValue(JSCell*) constructor is not explicit.
Attachments
[PATCH] Proposed Fix (1.43 KB, patch)
2016-02-18 23:47 PST, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2016-02-18 23:47:33 PST
Created attachment 271739 [details] [PATCH] Proposed Fix
WebKit Commit Bot
Comment 2 2016-02-19 02:39:31 PST
Comment on attachment 271739 [details] [PATCH] Proposed Fix Clearing flags on attachment: 271739 Committed r196810: <http://trac.webkit.org/changeset/196810>
WebKit Commit Bot
Comment 3 2016-02-19 02:39:35 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.