Bug 154434

Summary: Blocked plug-in placeholder is sometimes not shown.
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, esprehn+autocc, glenn, kondapallykalyan, simon.fraser
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description zalan 2016-02-18 21:07:39 PST
1. In Safari Preferences > Security > Plug-in Settings, set Flash or Quicktime to Ask or Block
2. Go to http://www.adobe.com/software/flash/about/
3. Repeatedly reload the page
Comment 1 zalan 2016-02-18 21:08:04 PST
rdar://problem/22584973
Comment 2 zalan 2016-02-18 21:23:36 PST
Created attachment 271729 [details]
Patch
Comment 3 zalan 2016-02-18 21:24:35 PST
Created attachment 271730 [details]
Patch
Comment 4 Brent Fulgham 2016-02-18 23:29:14 PST
Comment on attachment 271730 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=271730&action=review

Looks good. r=me.  I do wish we had some way to test this properly.

> Source/WebCore/rendering/RenderEmbeddedObject.h:97
> +    UnavailablePluginIndicatorState m_isUnavailablePluginIndicatorState { UnavailablePluginIndicatorState::Uninitialized };

Very nice!
Comment 5 WebKit Commit Bot 2016-02-19 03:48:18 PST
Comment on attachment 271730 [details]
Patch

Clearing flags on attachment: 271730

Committed r196813: <http://trac.webkit.org/changeset/196813>
Comment 6 WebKit Commit Bot 2016-02-19 03:48:23 PST
All reviewed patches have been landed.  Closing bug.