Bug 154431

Summary: AX: Inconsistency between CharacterOffset and VisiblePostition
Product: WebKit Reporter: Nan Wang <n_wang>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, jcraig, jdiggs, mario, n_wang, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch
none
patch none

Description Nan Wang 2016-02-18 17:45:47 PST
The previous/next text marker from CharacterOffset should be consistent with VisiblePosition so that node start and end will be included when navigating.
Comment 1 Radar WebKit Bug Importer 2016-02-18 17:47:25 PST
<rdar://problem/24733435>
Comment 2 Nan Wang 2016-02-18 18:05:53 PST
Created attachment 271720 [details]
patch
Comment 3 chris fleizach 2016-02-19 00:01:36 PST
Comment on attachment 271720 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=271720&action=review

> Source/WebCore/accessibility/AXObjectCache.cpp:1866
> +        // When VisiblePostion move to next node, it will count the leading line break as

"moves" to the next node

> Source/WebCore/accessibility/AXObjectCache.h:-199
> -    CharacterOffset nextCharacterOffset(const CharacterOffset&, bool ignoreStart = true);

it's not clear what ignoreStart/ignorePrevEnd means here. can you add a comment or rename this param?
/??
Comment 4 Nan Wang 2016-02-19 08:39:07 PST
Created attachment 271755 [details]
patch
Comment 5 WebKit Commit Bot 2016-02-19 10:58:29 PST
Comment on attachment 271755 [details]
patch

Clearing flags on attachment: 271755

Committed r196824: <http://trac.webkit.org/changeset/196824>
Comment 6 WebKit Commit Bot 2016-02-19 10:58:33 PST
All reviewed patches have been landed.  Closing bug.