Bug 15442

Summary: Cease "hacking" the scope chains of nested functions
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: JavaScriptCoreAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal CC: zwarich
Priority: P2    
Version: 523.x (Safari 3)   
Hardware: Mac   
OS: OS X 10.4   
Bug Depends on:    
Bug Blocks: 14868    
Attachments:
Description Flags
Patch
darin: review+
Patch2
darin: review+
Patch3
ggaren: review+
Patch4 ggaren: review+

Description Geoffrey Garen 2007-10-09 15:03:21 PDT
Broken off from bug 14868.
Comment 1 Geoffrey Garen 2007-10-09 15:04:22 PDT
Created attachment 16602 [details]
Patch
Comment 2 Darin Adler 2007-10-09 15:08:34 PDT
Comment on attachment 16602 [details]
Patch

r=me
Comment 3 Geoffrey Garen 2007-10-09 15:10:00 PDT
Created attachment 16603 [details]
Patch2

Slightly updated test case and ChangeLog to reflect the full scope of this change.
Comment 4 Darin Adler 2007-10-09 15:10:49 PDT
Comment on attachment 16603 [details]
Patch2

r=me
Comment 5 Geoffrey Garen 2007-10-09 15:13:28 PDT
Created attachment 16604 [details]
Patch3

This one includes the updated layout test results, too. (I guess I'll r+ it myself.)
Comment 6 Geoffrey Garen 2007-10-09 15:24:56 PDT
Created attachment 16605 [details]
Patch4

One more time with the right layout test results. This time for sure!
Comment 7 Geoffrey Garen 2007-10-15 13:54:10 PDT
Committed revision 26621.