Bug 154406

Summary: Web Inspector: CSS var() function should be syntax highlighted
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: All   
OS: All   
Description Flags
[Patch] Proposed Fix none

Description Timothy Hatcher 2016-02-18 12:41:52 PST
The var() is black, while the text inside is highlighted correctly as a property now.
Comment 1 Radar WebKit Bug Importer 2016-02-18 12:42:16 PST
Comment 2 Matt Baker 2016-02-18 15:50:53 PST
"var" is in the valueKeywords_ array in External/CodeMirror/css.js, so it seems like it should just work. "calc" is in the same array, and appears correctly.
Comment 3 Timothy Hatcher 2016-02-18 16:15:09 PST
We replace CodeMirrors valueKeywords in WebInspector.CSSCompletions.requestCSSCompletions.
Comment 4 Matt Baker 2016-02-19 14:01:16 PST
Created attachment 271796 [details]
[Patch] Proposed Fix
Comment 5 WebKit Commit Bot 2016-02-19 15:56:23 PST
Comment on attachment 271796 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 271796

Committed r196843: <http://trac.webkit.org/changeset/196843>
Comment 6 WebKit Commit Bot 2016-02-19 15:56:28 PST
All reviewed patches have been landed.  Closing bug.