Modern IDB: Implement client->server operations in WK2

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Brady Eidson]

Modern IDB: Implement client->server operations in WK2

Since the server can't yet reply to the client, nothing actually works, and no behavior is changed.

But that's coming *very* soon.

[Brady Eidson]

Created attachment 271670 [details]
Patch v1

[WebKit Commit Bot]

Attachment 271670 [details] did not pass style-queue:


ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/WebIDBConnectionToClient.cpp:216:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/WebIDBConnectionToClient.cpp:216:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/WebIDBConnectionToClient.cpp:217:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Total errors found: 3 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

Comment on attachment 271670 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=271670&action=review

> Source/WebCore/Modules/indexeddb/server/IDBServer.h:51
> +class IDBBackingStore;

This doesn't seem necessary.

> Source/WebKit2/DatabaseProcess/IndexedDB/WebIDBConnectionToClient.cpp:217
> +    if (overwriteMode != static_cast<unsigned>(IndexedDB::ObjectStoreOverwriteMode::NoOverwrite) &&
> +        overwriteMode != static_cast<unsigned>(IndexedDB::ObjectStoreOverwriteMode::Overwrite) &&

Style bot doesn't like the &&

> Source/WebKit2/DatabaseProcess/IndexedDB/WebIDBConnectionToClient.cpp:219
> +        // FIXME: Corrupt message from the WebProcess. It should be killed, or something.

I'm not sure this FIXME is necessary.  We are already doing an early return, which is what we should do in this case.

[Brady Eidson]

(In reply to comment #3)
> Comment on attachment 271670 [details]
> Patch v1
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=271670&action=review
> 
> > Source/WebCore/Modules/indexeddb/server/IDBServer.h:51
> > +class IDBBackingStore;
> 
> This doesn't seem necessary.

It was at one time, I'll go double check now.

> 
> > Source/WebKit2/DatabaseProcess/IndexedDB/WebIDBConnectionToClient.cpp:217
> > +    if (overwriteMode != static_cast<unsigned>(IndexedDB::ObjectStoreOverwriteMode::NoOverwrite) &&
> > +        overwriteMode != static_cast<unsigned>(IndexedDB::ObjectStoreOverwriteMode::Overwrite) &&
> 
> Style bot doesn't like the &&

Yah, stupid style bot.

> 
> > Source/WebKit2/DatabaseProcess/IndexedDB/WebIDBConnectionToClient.cpp:219
> > +        // FIXME: Corrupt message from the WebProcess. It should be killed, or something.
> 
> I'm not sure this FIXME is necessary.  We are already doing an early return,
> which is what we should do in this case.

I need to reword the FIXME - That was my own placeholder to do so later.

But it still stands, I think.

[Brady Eidson]

Created attachment 271674 [details]
Patch for landing v5

[WebKit Commit Bot]

Comment on attachment 271674 [details]
Patch for landing v5

Clearing flags on attachment: 271674

Committed r196771: <http://trac.webkit.org/changeset/196771>