Bug 154395

Summary: Fix pessimizing-move warnings
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: New BugsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 145121    
Attachments:
Description Flags
Patch none

Csaba Osztrogonác
Reported 2016-02-18 06:07:40 PST
../../Source/WebCore/platform/graphics/efl/CairoUtilitiesEfl.cpp:85:12: warning: moving a local object in a return statement prevents copy elision [-Wpessimizing-move] return std::move<WTF::CheckMoveParameter>(image); ^ ../../Source/WebCore/platform/graphics/efl/CairoUtilitiesEfl.cpp:85:12: note: remove std::move call here return std::move<WTF::CheckMoveParameter>(image); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~ ../../Source/WebCore/platform/graphics/surfaces/GLTransportSurface.cpp:56:16: warning: moving a local object in a return statement prevents copy elision [-Wpessimizing-move] return std::move<WTF::CheckMoveParameter>(surface); ^ ../../Source/WebCore/platform/graphics/surfaces/GLTransportSurface.cpp:56:16: note: remove std::move call here return std::move<WTF::CheckMoveParameter>(surface); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~ ../../Source/WebCore/platform/graphics/surfaces/GLTransportSurface.cpp:223:12: warning: moving a local object in a return statement prevents copy elision [-Wpessimizing-move] return std::move<WTF::CheckMoveParameter>(client); ^ ../../Source/WebCore/platform/graphics/surfaces/GLTransportSurface.cpp:223:12: note: remove std::move call here return std::move<WTF::CheckMoveParameter>(client); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~
Attachments
Patch (2.31 KB, patch)
2016-02-18 06:08 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2016-02-18 06:08:36 PST
Created attachment 271657 [details] Patch
WebKit Commit Bot
Comment 2 2016-02-19 02:48:58 PST
Comment on attachment 271657 [details] Patch Clearing flags on attachment: 271657 Committed r196811: <http://trac.webkit.org/changeset/196811>
WebKit Commit Bot
Comment 3 2016-02-19 02:49:02 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.