Bug 154395 - Fix pessimizing-move warnings
Summary: Fix pessimizing-move warnings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks: 145121
  Show dependency tree / graph
 
Reported: 2016-02-18 06:07 PST by Csaba Osztrogonác
Modified: 2016-02-19 07:56 PST (History)
1 user (show)

See Also:

Attachments
Patch (2.31 KB, patch)
2016-02-18 06:08 PST, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2016-02-18 06:07:40 PST 
../../Source/WebCore/platform/graphics/efl/CairoUtilitiesEfl.cpp:85:12: warning: moving a local object in a return statement prevents copy elision [-Wpessimizing-move]
    return std::move<WTF::CheckMoveParameter>(image);
           ^
../../Source/WebCore/platform/graphics/efl/CairoUtilitiesEfl.cpp:85:12: note: remove std::move call here
    return std::move<WTF::CheckMoveParameter>(image);
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~     ~


../../Source/WebCore/platform/graphics/surfaces/GLTransportSurface.cpp:56:16: warning: moving a local object in a return statement prevents copy elision [-Wpessimizing-move]
        return std::move<WTF::CheckMoveParameter>(surface);
               ^
../../Source/WebCore/platform/graphics/surfaces/GLTransportSurface.cpp:56:16: note: remove std::move call here
        return std::move<WTF::CheckMoveParameter>(surface);
               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~       ~


../../Source/WebCore/platform/graphics/surfaces/GLTransportSurface.cpp:223:12: warning: moving a local object in a return statement prevents copy elision [-Wpessimizing-move]
    return std::move<WTF::CheckMoveParameter>(client);
           ^
../../Source/WebCore/platform/graphics/surfaces/GLTransportSurface.cpp:223:12: note: remove std::move call here
    return std::move<WTF::CheckMoveParameter>(client);
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~      ~
Comment 1 Csaba Osztrogonác 2016-02-18 06:08:36 PST 
Created attachment 271657 [details]
Patch
Comment 2 WebKit Commit Bot 2016-02-19 02:48:58 PST 
Comment on attachment 271657 [details]
Patch

Clearing flags on attachment: 271657

Committed r196811: <http://trac.webkit.org/changeset/196811>
Comment 3 WebKit Commit Bot 2016-02-19 02:49:02 PST 
All reviewed patches have been landed.  Closing bug.