Bug 154365

Summary:

Rename FTLB3Blah to FTLBlah

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, joepeck

Priority:

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
the patch	none
the pqtch	none

Filip Pizlo

Reported 2016-02-17 16:30:51 PST

Patch forthcoming.

Attachments
the patch (95.80 KB, patch) 2016-02-17 16:32 PST, Filip Pizlo	no flags	Details Formatted Diff Diff
the pqtch (97.91 KB, patch) 2016-02-17 16:37 PST, Filip Pizlo	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Filip Pizlo

Comment 1 2016-02-17 16:31:18 PST

RS=ggaren, benjamin, and awesomekling.

Filip Pizlo

Comment 2 2016-02-17 16:32:26 PST

Created attachment 271604 [details] the patch

WebKit Commit Bot

Comment 3 2016-02-17 16:34:04 PST

Attachment 271604 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/ftl/FTLOutput.cpp:27: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/JavaScriptCore/ftl/FTLOutput.cpp:129: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/ftl/FTLOutput.cpp:141: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/ftl/FTLOutput.cpp:219: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:26: #ifndef header guard has wrong style, please use: FTLOutput_h [build/header_guard] [5] ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:222: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:222: The parameter name "pointer" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:223: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:223: The parameter name "pointer" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:529: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/ftl/FTLCompile.cpp:35: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/JavaScriptCore/ftl/FTLCompile.cpp:130: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 12 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.

Filip Pizlo

Comment 4 2016-02-17 16:37:23 PST

Created attachment 271605 [details] the pqtch fix buidl

WebKit Commit Bot

Comment 5 2016-02-17 16:38:56 PST

Attachment 271605 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/ftl/FTLOutput.cpp:129: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/ftl/FTLOutput.cpp:141: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/ftl/FTLOutput.cpp:219: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:222: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:222: The parameter name "pointer" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:223: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:223: The parameter name "pointer" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:529: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/ftl/FTLCompile.cpp:35: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/JavaScriptCore/ftl/FTLCompile.cpp:130: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 10 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.

Joseph Pecoraro

Comment 6 2016-04-29 19:08:52 PDT

This landed: <https://trac.webkit.org/changeset/196731>

Note You need to log in before you can comment on or make changes to this bug.