Summary: | Rename FTLB3Blah to FTLBlah | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||||
Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, joepeck | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Filip Pizlo
2016-02-17 16:30:51 PST
RS=ggaren, benjamin, and awesomekling. Created attachment 271604 [details]
the patch
Attachment 271604 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/ftl/FTLOutput.cpp:27: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.cpp:129: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.cpp:141: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.cpp:219: Multi line control clauses should use braces. [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:26: #ifndef header guard has wrong style, please use: FTLOutput_h [build/header_guard] [5]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:222: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:222: The parameter name "pointer" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:223: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:223: The parameter name "pointer" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:529: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/ftl/FTLCompile.cpp:35: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Source/JavaScriptCore/ftl/FTLCompile.cpp:130: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 12 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 271605 [details]
the pqtch
fix buidl
Attachment 271605 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/ftl/FTLOutput.cpp:129: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.cpp:141: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.cpp:219: Multi line control clauses should use braces. [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:222: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:222: The parameter name "pointer" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:223: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:223: The parameter name "pointer" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:529: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/ftl/FTLCompile.cpp:35: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Source/JavaScriptCore/ftl/FTLCompile.cpp:130: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 10 in 8 files
If any of these errors are false positives, please file a bug against check-webkit-style.
This landed: <https://trac.webkit.org/changeset/196731> |