Bug 154363

Summary: Modern IDB: Rename some "UniqueIDBDatabase" classes that conflict with new classes in WebCore
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit2Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue
Priority: P2    
Version: Safari 9   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 149117, 153808    
Attachments:
Description Flags
Patch v1 none

Description Brady Eidson 2016-02-17 16:09:17 PST 
Modern IDB: Rename some "UniqueIDBDatabase" classes that conflict with new classes in WebCore

Even though they're in different namespaces, especially with header guards being the same, this is making https://bugs.webkit.org/show_bug.cgi?id=153808 hard to work on
Comment 1 Brady Eidson 2016-02-17 16:14:39 PST 
Created attachment 271602 [details]
Patch v1
Comment 2 WebKit Commit Bot 2016-02-17 16:16:51 PST 
Attachment 271602 [details] did not pass style-queue:


ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:36:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/LegacyUniqueIDBDatabase.h:84:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/LegacyUniqueIDBDatabase.h:86:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/LegacyUniqueIDBDatabase.h:88:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/LegacyUniqueIDBDatabase.h:89:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/LegacyUniqueIDBDatabase.h:90:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/LegacyUniqueIDBDatabase.h:91:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/LegacyUniqueIDBDatabase.h:92:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/LegacyUniqueIDBDatabase.h:94:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/LegacyUniqueIDBDatabase.h:95:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/LegacyUniqueIDBDatabase.h:96:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/LegacyUniqueIDBDatabase.h:97:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/LegacyUniqueIDBDatabase.h:98:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/LegacyUniqueIDBDatabase.h:99:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/LegacyUniqueIDBDatabase.h:101:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/LegacyUniqueIDBDatabase.h:102:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/LegacyUniqueIDBDatabase.h:104:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/LegacyUniqueIDBDatabase.h:105:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/LegacyUniqueIDBDatabase.h:106:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/LegacyUniqueIDBDatabase.h:108:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/LegacyUniqueIDBDatabase.h:109:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/LegacyUniqueIDBDatabase.h:141:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/LegacyUniqueIDBDatabase.cpp:191:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/LegacyUniqueIDBDatabase.cpp:215:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/LegacyUniqueIDBDatabase.cpp:286:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/LegacyUniqueIDBDatabase.cpp:291:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/LegacyUniqueIDBDatabase.cpp:296:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/LegacyUniqueIDBDatabase.cpp:301:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/LegacyUniqueIDBDatabase.cpp:306:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/LegacyUniqueIDBDatabase.cpp:311:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/LegacyUniqueIDBDatabase.cpp:350:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/LegacyUniqueIDBDatabase.cpp:412:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/LegacyUniqueIDBDatabase.cpp:440:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/LegacyUniqueIDBDatabase.cpp:467:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/LegacyUniqueIDBDatabase.cpp:490:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/LegacyUniqueIDBDatabase.cpp:524:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/LegacyUniqueIDBDatabase.cpp:558:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/LegacyUniqueIDBDatabase.cpp:581:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/LegacyUniqueIDBDatabase.cpp:604:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/LegacyUniqueIDBDatabase.cpp:627:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/LegacyUniqueIDBDatabase.cpp:648:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/LegacyUniqueIDBDatabase.cpp:669:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/LegacyUniqueIDBDatabase.cpp:690:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 43 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Commit Bot 2016-02-17 17:25:21 PST 
Comment on attachment 271602 [details]
Patch v1

Clearing flags on attachment: 271602

Committed r196735: <http://trac.webkit.org/changeset/196735>
Comment 4 WebKit Commit Bot 2016-02-17 17:25:24 PST 
All reviewed patches have been landed.  Closing bug.