Bug 154343

Summary: [iOS] Purge GraphicsServices font cache on memory warning.
Product: WebKit Reporter: Andreas Kling <kling>
Component: TextAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, mmaxfield, ryanhaddad
Priority: P2 Keywords: Performance
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 154371    
Bug Blocks:    
Attachments:
Description Flags
Potch
none
Patch for landing
none
Patch for landing
none
Patch for landing none

Description Andreas Kling 2016-02-17 10:53:28 PST 
Platform objects for CSS fonts currently survive fake memory warnings due to the GS font cache retaining them.
Comment 1 Andreas Kling 2016-02-17 10:54:58 PST 
Created attachment 271565 [details]
Potch
Comment 2 WebKit Commit Bot 2016-02-17 12:27:55 PST 
Comment on attachment 271565 [details]
Potch

Clearing flags on attachment: 271565

Committed r196712: <http://trac.webkit.org/changeset/196712>
Comment 3 WebKit Commit Bot 2016-02-17 12:28:00 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Ryan Haddad 2016-02-17 17:19:32 PST 
It looks like this change may have caused new API test failures on ios-simulator

<https://build.webkit.org/builders/Apple%20iOS%209%20Simulator%20Release%20WK2%20%28Tests%29/builds/3185>

Tests that failed:
  WKUserContentController.AddUserStyleSheetAfterCreatingView
  WKUserContentController.AddUserStyleSheetBeforeCreatingView
  WebKit2.BundleParameters

Tests that timed out:
  WKWebView.LoadAlternateHTMLStringFromProvisionalLoadError
  WebKit2.RemoteObjectRegistry
Comment 5 Ryan Haddad 2016-02-17 17:35:27 PST 
I ran API tests with and without this change locally, and it does appear that it causes the failures.
Comment 6 WebKit Commit Bot 2016-02-17 18:00:25 PST 
Re-opened since this is blocked by bug 154371
Comment 7 Andreas Kling 2017-01-02 06:56:36 PST 
Created attachment 297897 [details]
Patch for landing
Comment 8 Andreas Kling 2017-01-12 11:52:04 PST 
Created attachment 298703 [details]
Patch for landing

Surprised that this doesn't link on iOS EWS. Trying a re-upload before diving deeper.
Comment 9 Andreas Kling 2017-01-12 14:48:13 PST 
Created attachment 298711 [details]
Patch for landing
Comment 10 WebKit Commit Bot 2017-01-12 16:48:42 PST 
Comment on attachment 298711 [details]
Patch for landing

Clearing flags on attachment: 298711

Committed r210688: <http://trac.webkit.org/changeset/210688>
Comment 11 WebKit Commit Bot 2017-01-12 16:48:47 PST 
All reviewed patches have been landed.  Closing bug.