Bug 154337

Summary: [cmake] Build system cleanup
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: JavaScriptCoreAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, commit-queue, fpizlo, ggaren, gyuyoung.kim, ossy
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Csaba Osztrogonác
Reported 2016-02-17 06:26:46 PST
Now runtime/* sources and llint/* sources are added to JavaScriptCore_SOURCES unconditionally, but in a different place. Let's move them to the main list. And there is no need to add ftl/* sources conditionally to JavaScriptCore_SOURCES. FTL JIT is enabled almost everywhere and these files are guarded properly, no need to have a build system condition too.
Attachments
Patch (6.89 KB, patch)
2016-02-17 06:30 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Patch (6.41 KB, patch)
2016-02-18 00:52 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Patch (5.94 KB, patch)
2016-02-18 01:38 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2016-02-17 06:30:51 PST
Created attachment 271551 [details] Patch
Gyuyoung Kim
Comment 2 2016-02-17 17:27:50 PST
Comment on attachment 271551 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=271551&action=review > Source/JavaScriptCore/CMakeLists.txt:-995 > -if (ENABLE_FTL_JIT) Personally I don't like to use guard in *.cmake though, I know win port doesn't enable FTL JIT yet. It looks there are still people to use guard in cmake files.
Csaba Osztrogonác
Comment 3 2016-02-17 23:43:34 PST
(In reply to comment #2) > Comment on attachment 271551 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=271551&action=review > > > Source/JavaScriptCore/CMakeLists.txt:-995 > > -if (ENABLE_FTL_JIT) > > Personally I don't like to use guard in *.cmake though, I know win port > doesn't enable FTL JIT yet. It looks there are still people to use guard in > cmake files. As I said, FTL JIT files are guarded properly, there is no reason to duplicate these guards in the build system too. It is a common design in WebKit, that we add source files unconditionally in the build system. FTL JIT shouldn't be an exception.
Csaba Osztrogonác
Comment 4 2016-02-18 00:52:00 PST
Created attachment 271643 [details] Patch updated to ToT
Csaba Osztrogonác
Comment 5 2016-02-18 01:38:44 PST
Created attachment 271644 [details] Patch really updated to ToT
Zan Dobersek
Comment 6 2016-02-18 01:45:04 PST
Comment on attachment 271644 [details] Patch The GTK+ CQ is a bit overflown, I'll ping the appropriate people. I don't think this should cause build problems as it is, though.
WebKit Commit Bot
Comment 7 2016-02-18 02:34:46 PST
Comment on attachment 271644 [details] Patch Clearing flags on attachment: 271644 Committed r196752: <http://trac.webkit.org/changeset/196752>
WebKit Commit Bot
Comment 8 2016-02-18 02:34:52 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.