Bug 154334

Summary: JSDOMWindow::put should not do the same thing twice in different ways
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: BindingsAssignee: Gavin Barraclough <barraclough>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fix cdumez: review+

Description Gavin Barraclough 2016-02-17 00:59:19 PST
It either calls JSGlobalObject::put or Base::put. Hint: these are basically the same thing. In the latter case it might call lookupPut. That's redundant; JSObject::put handles static table entries.
Comment 1 Gavin Barraclough 2016-02-17 01:04:34 PST
Created attachment 271547 [details]
Fix
Comment 2 Gavin Barraclough 2016-02-17 01:05:15 PST
All red patch! Whoooo!
Comment 3 Chris Dumez 2016-02-17 08:45:37 PST
Comment on attachment 271547 [details]
Fix

r=me
Comment 4 Gavin Barraclough 2016-02-17 11:26:37 PST
Transmitting file data ....
Committed revision 196702.