Summary: | Implement Proxy.[[HasProperty]] | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Saam Barati <saam> | ||||||||
Component: | JavaScriptCore | Assignee: | Saam Barati <saam> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | benjamin, commit-queue, fpizlo, ggaren, gskachkov, keith_miller, mark.lam, msaboff, oliver, sukolsak, ysuzuki | ||||||||
Priority: | P2 | ||||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | 154081 | ||||||||||
Bug Blocks: | 35731 | ||||||||||
Attachments: |
|
Description
Saam Barati
2016-02-16 15:22:26 PST
Created attachment 271641 [details]
WIP
Basically done, just need to write tests.
This contains some of the patch for [[GetOwnProperty]], so we need to wait for that to land before landing this.
Created attachment 271707 [details]
patch
Attachment 271707 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/runtime/ProxyObject.cpp:242: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Total errors found: 1 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 271709 [details]
patch
with a changelog this time
Attachment 271709 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/runtime/ProxyObject.cpp:242: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Total errors found: 1 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
landed in: http://trac.webkit.org/changeset/196789 |