Bug 154304

Summary: Navigator.geolocation should not be marked a [Replaceable] and should be on the prototype
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, benjamin, buildbot, cgarcia, commit-queue, dbates, esprehn+autocc, ggaren, kondapallykalyan, oliver, rniwa, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar, WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: https://dev.w3.org/geo/api/spec-source.html#geolocation_interface
See Also: https://bugs.webkit.org/show_bug.cgi?id=133559
https://bugs.webkit.org/show_bug.cgi?id=154257
https://bugs.webkit.org/show_bug.cgi?id=133221
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews101 for mac-yosemite
none
Patch none

Description Chris Dumez 2016-02-16 12:49:34 PST 
Navigator.geolocation should not be marked a [Replaceable]:
https://dev.w3.org/geo/api/spec-source.html#geolocation_interface

This was done as a workaround for an Amazon App bug in Bug 133559 but has the following unwanted behavior now that our bindings are behaving in a more standard way:
navigator.geolocation = 1
console.log(navigator.geolocation) -> prints 1 instead of the Geolocation object.

We need to test if this workaround is still needed by the Amazon app and find a better workaround if it is.
Comment 1 Chris Dumez 2016-02-16 14:17:43 PST 
Moving the Navigator properties to the prototype and dropping the [Replaceable] for Navigator.geolocation, I have verified that rdar://problem/16332749 no longer reproduces in the latest Amazon iOS app.
Comment 2 Radar WebKit Bug Importer 2016-02-16 14:32:17 PST 
<rdar://problem/24685092>
Comment 3 Chris Dumez 2016-02-16 14:45:26 PST 
Firefox and Chrome both don't allow replacing Navigator.geolocation. Both throw an exception when trying to set Navigator.geolocation in strict mode.
Comment 4 Chris Dumez 2016-02-16 15:25:53 PST 
Created attachment 271495 [details]
Patch
Comment 5 Build Bot 2016-02-16 16:18:27 PST 
Comment on attachment 271495 [details]
Patch

Attachment 271495 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/842221

New failing tests:
fast/dom/Geolocation/enabled.html
js/dom/delete-syntax.html
Comment 6 Build Bot 2016-02-16 16:18:34 PST 
Created attachment 271503 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 7 Chris Dumez 2016-02-16 16:20:32 PST 
Created attachment 271504 [details]
Patch
Comment 8 Chris Dumez 2016-02-16 17:11:26 PST 
Comment on attachment 271504 [details]
Patch

Clearing flags on attachment: 271504

Committed r196673: <http://trac.webkit.org/changeset/196673>
Comment 9 Chris Dumez 2016-02-16 17:11:32 PST 
All reviewed patches have been landed.  Closing bug.