Bug 154292

Summary: AX: Change "dialog" role description to "web dialog" so users can distinguish from native alerts
Product: WebKit Reporter: James Craig <jcraig>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: NEW    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, jdiggs, mario, mitz, n_wang, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari 9   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch cfleizach: review+

James Craig
Reported 2016-02-16 10:48:23 PST
AX: Change "dialog" role description to "web dialog" so users can distinguish from native alerts
Attachments
patch (3.82 KB, patch)
2016-03-22 10:58 PDT, Nan Wang 		cfleizach: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-02-16 10:53:55 PST
<rdar://problem/24679586>
James Craig
Comment 2 2016-02-17 14:55:04 PST
Potentially need to do something separate for alert dialogs: "alert dialog (web)", "alert web dialog", "web alert dialog", or just "web alert"?
Nan Wang
Comment 3 2016-03-22 10:58:05 PDT
Created attachment 274663 [details] patch
Nan Wang
Comment 4 2016-03-22 12:19:06 PDT
https://trac.webkit.org/changeset/198543
mitz
Comment 5 2016-06-19 09:57:22 PDT
The strings file is automatically generated from source using update-webkit-localizable-strings, so the right fix for this is to change LocalizedStrings.cpp. Otherwise, the values will revert the next time the strings file is regenerated. I am going to include the change to LocalizedStrings.cpp in an upcoming patch, though.
Note You need to log in before you can comment on or make changes to this bug.