Bug 154291 – [CSS Grid Layout Refactoring some layout tests

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Javier Fernandez]

There are several tests using specific CSS rules with different sizing values, like fit-content, fill-content, ... In order to deal with different prefix and evaluate the browser interoperability we need to refactor some of the grid layout tests so they use shared CSS classes.

[Javier Fernandez]

Created attachment 271446 [details]
Patch

[Sergio Villar Senin]

Comment on attachment 271446 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=271446&action=review

Nice changes.

> LayoutTests/fast/css-grid-layout/calc-resolution-grid-item.html:28
> +    height: calc(70% + 30%);

Didn't know that this was already unprefixed in WebKit.

> LayoutTests/fast/css-grid-layout/resources/grid.css:313
>      -webkit-writing-mode: vertical-rl;

Why do we need prefixed and unprefixed?

> LayoutTests/fast/css-grid-layout/resources/grid.css:316
> +    writing-mode: vertical-lr;

Ditto.

> LayoutTests/fast/css-grid-layout/resources/grid.css:321
> +    -webkit-writing-mode: horizontal-tb;

Ditto.

> LayoutTests/fast/css-grid-layout/resources/grid.css:325
>      -webkit-writing-mode: horizontal-bt;

Ditto.

[Javier Fernandez]

(In reply to comment #2)
> Comment on attachment 271446 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=271446&action=review
> 
> Nice changes.
> 
> > LayoutTests/fast/css-grid-layout/calc-resolution-grid-item.html:28
> > +    height: calc(70% + 30%);
> 
> Didn't know that this was already unprefixed in WebKit.

It is, as far as I know.

> 
> > LayoutTests/fast/css-grid-layout/resources/grid.css:313
> >      -webkit-writing-mode: vertical-rl;
> 
> Why do we need prefixed and unprefixed?

The purpose of this patch is to ease the execution of the tests in different browsers. WebKit still has prefix for this CSS property, while Blink and Firefox don't 

> 
> > LayoutTests/fast/css-grid-layout/resources/grid.css:316
> > +    writing-mode: vertical-lr;
> 
> Ditto.

Replied.

> 
> > LayoutTests/fast/css-grid-layout/resources/grid.css:321
> > +    -webkit-writing-mode: horizontal-tb;
> 
> Ditto.
> 

Replied.

> > LayoutTests/fast/css-grid-layout/resources/grid.css:325
> >      -webkit-writing-mode: horizontal-bt;
> 
> Ditto.

Replied.

[WebKit Commit Bot]

Comment on attachment 271446 [details]
Patch

Clearing flags on attachment: 271446

Committed r196819: <http://trac.webkit.org/changeset/196819>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.