Bug 154277

Summary:

Extract the code specific to v2 UI out of shared statistics.js

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

Perf Dashboard

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, kling, koivisto, rniwa, slewis

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Cleanup	cdumez: review+, cdumez: commit-queue-

Description Ryosuke Niwa 2016-02-15 20:39:42 PST

Extract the code specific to v2 UI (and the current implementation of detect-changes.js) out of statistics.js

This re-factoring is needed to support statistical tools in v3 UI.

Comment 1 Ryosuke Niwa 2016-02-15 20:54:18 PST

Created attachment 271412 [details]
Cleanup

Comment 2 Chris Dumez 2016-02-16 13:39:15 PST

Comment on attachment 271412 [details]
Cleanup

View in context: https://bugs.webkit.org/attachment.cgi?id=271412&action=review

rs=me

> Websites/perf.webkit.org/ChangeLog:8
> +        Extracted statistics-strategies.js out of statistics.js for v2 UI and detect-changes.js. The indent is to

"intent" ?

> Websites/perf.webkit.org/public/shared/statistics.js:136
> +    this.cumultaiveMovingAverage = function (values) {

"cumulative".

> Websites/perf.webkit.org/public/v2/statistics-strategies.js:21
> +        execute: Statistics.cumultaiveMovingAverage,

"cumulative"

Comment 3 Ryosuke Niwa 2016-02-16 15:16:21 PST

Committed r196663: <http://trac.webkit.org/changeset/196663>