Bug 154255

Summary: stress/sampling-profiler-deep-stack.js fails on ARM 32bit
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, fpizlo, ggaren, gskachkov, keith_miller, mark.lam, msaboff, oliver, sukolsak, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch mark.lam: review+

Saam Barati
Reported 2016-02-15 13:42:10 PST
...
Attachments
patch (1.54 KB, patch)
2016-02-16 12:35 PST, Saam Barati 		mark.lam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-02-15 14:15:48 PST
<rdar://problem/24662996>
Saam Barati
Comment 2 2016-02-16 12:35:07 PST
Created attachment 271468 [details] patch
Mark Lam
Comment 3 2016-02-16 12:43:26 PST
Comment on attachment 271468 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=271468&action=review r=me with improved comment. > Source/JavaScriptCore/ChangeLog:12 > + The DFG was doing a good job at optimizing the function > + at the leaf of the recursion. Because of that, we often > + wouldn't sample it. I fixed this by making the leaf > + function do more work. It's not clear from this comment that this test failure does not reflect a bug in the VM. Instead, it is the test that is not set up to meet its own expectations. Hence, the fix requires that the test be modified. Can you update the comment to say something to that effect?
Saam Barati
Comment 4 2016-02-16 12:51:05 PST
landed fix in: https://trac.webkit.org/changeset/196650
Note You need to log in before you can comment on or make changes to this bug.