Bug 154248

Summary: Null-deref crash in DefaultAudioDestinationNode::suspend()
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch achristensen: review+, mcatanzaro: commit-queue-

Jer Noble
Reported 2016-02-15 11:00:01 PST
Null-deref crash in DefaultAudioDestinationNode::suspend()
Attachments
Patch (106.04 KB, patch)
2016-02-15 11:03 PST, Jer Noble 		achristensen: review+
mcatanzaro: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2016-02-15 11:00:31 PST
rdar://problem/21478816
Jer Noble
Comment 2 2016-02-15 11:03:25 PST
Created attachment 271349 [details] Patch
WebKit Commit Bot
Comment 3 2016-02-15 11:06:03 PST
Attachment 271349 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/webaudio/AudioContext.h:401: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/Modules/webaudio/AudioContext.h:405: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 2 in 61 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alex Christensen
Comment 4 2016-02-15 13:16:13 PST
Comment on attachment 271349 [details] Patch That's quite a patch for adding 3 null checks. r=me
Michael Catanzaro
Comment 5 2016-02-15 13:44:45 PST
Comment on attachment 271349 [details] Patch *Please* split this nice change into two patches before committing, it makes it unnecessarily hard to see the real fix.
Jer Noble
Comment 6 2016-02-15 14:35:35 PST
(In reply to comment #5) > Comment on attachment 271349 [details] > Patch > > *Please* split this nice change into two patches before committing, it makes > it unnecessarily hard to see the real fix. Sure thing. I'll commit in two steps.
Jer Noble
Comment 7 2016-02-15 14:38:56 PST
Committed r196602: <http://trac.webkit.org/changeset/196602>
Jer Noble
Comment 8 2016-02-15 14:39:19 PST
Committed r196603: <http://trac.webkit.org/changeset/196603>
Note You need to log in before you can comment on or make changes to this bug.