Bug 154237

Summary: Web Inspector: Visual sidebar minor regression fixes
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
timothy: review+, timothy: commit-queue-
Patch none

Description Devin Rousso 2016-02-15 03:16:33 PST
Each one of these issues is minor by themselves, so I figured that they could be merged into a single bug.  Here are the problems:
- r194728 <https://bugs.webkit.org/show_bug.cgi?id=152755>: Used Visual sidebar default unit lists by reference (not copying them), meaning that any modifications resulted in all future uses of that list to have said modifications.
- r196266 <https://bugs.webkit.org/show_bug.cgi?id=153890>: Visual sidebar comma separated value lists to no update their width's when the width of the sidebar is changed.
- r196266 <https://bugs.webkit.org/show_bug.cgi?id=153890>: Placeholder items in Visual sidebar comma separated value lists are prepended with "-"
- Modifying values after closing sections with values for the selected rule (which were automatically opened) causes those closed sections to reopen and the scroll position to shift
- Visual sidebar comma separated value lists do not hide the placeholder element used for the computed value of the property.
Comment 1 Radar WebKit Bug Importer 2016-02-15 03:16:47 PST
<rdar://problem/24653135>
Comment 2 Devin Rousso 2016-02-15 03:22:31 PST
Created attachment 271334 [details]
Patch
Comment 3 Timothy Hatcher 2016-02-15 13:27:41 PST
Comment on attachment 271334 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=271334&action=review

> Source/WebInspectorUI/UserInterface/Views/VisualStyleDetailsPanel.js:118
> +    widthDidChange()
> +    {

This needs to call super.widthDidChange().
Comment 4 Devin Rousso 2016-02-15 15:51:02 PST
Created attachment 271385 [details]
Patch
Comment 5 WebKit Commit Bot 2016-02-15 16:50:21 PST
Comment on attachment 271385 [details]
Patch

Clearing flags on attachment: 271385

Committed r196610: <http://trac.webkit.org/changeset/196610>
Comment 6 WebKit Commit Bot 2016-02-15 16:50:24 PST
All reviewed patches have been landed.  Closing bug.