Bug 154231

Summary:

Refactor LazyEventListener creation to separate Element and Document cases

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

UI Events

Assignee:

Darin Adler <darin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, mcatanzaro, rniwa

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews101 for mac-yosemite	none
Archive of layout-test-results from ews107 for mac-yosemite-wk2	none
Archive of layout-test-results from ews117 for mac-yosemite	none
Patch	none
Patch	none

Darin Adler

Reported 2016-02-14 19:18:33 PST

Refactor LazyEventListener creation to separate Element and Document cases

Attachments
Patch (18.39 KB, patch) 2016-02-14 19:25 PST, Darin Adler	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-yosemite (497.73 KB, application/zip) 2016-02-14 20:08 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews107 for mac-yosemite-wk2 (301.13 KB, application/zip) 2016-02-14 20:11 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews117 for mac-yosemite (380.61 KB, application/zip) 2016-02-14 20:15 PST, Build Bot	no flags	Details
Patch (18.52 KB, patch) 2016-02-20 20:24 PST, Darin Adler	no flags	Details Formatted Diff Diff
Patch (19.59 KB, patch) 2016-02-21 16:31 PST, Darin Adler	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Darin Adler

Comment 1 2016-02-14 19:25:28 PST

Created attachment 271318 [details] Patch

WebKit Commit Bot

Comment 2 2016-02-14 19:28:02 PST

Attachment 271318 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 3 2016-02-14 20:08:55 PST

Comment on attachment 271318 [details] Patch Attachment 271318 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/833262 Number of test failures exceeded the failure limit.

Build Bot

Comment 4 2016-02-14 20:08:57 PST

Created attachment 271321 [details] Archive of layout-test-results from ews101 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 5 2016-02-14 20:11:29 PST

Comment on attachment 271318 [details] Patch Attachment 271318 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/833267 Number of test failures exceeded the failure limit.

Build Bot

Comment 6 2016-02-14 20:11:31 PST

Created attachment 271322 [details] Archive of layout-test-results from ews107 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Build Bot

Comment 7 2016-02-14 20:15:11 PST

Comment on attachment 271318 [details] Patch Attachment 271318 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/833259 Number of test failures exceeded the failure limit.

Build Bot

Comment 8 2016-02-14 20:15:14 PST

Created attachment 271324 [details] Archive of layout-test-results from ews117 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-yosemite Platform: Mac OS X 10.10.5

Darin Adler

Comment 9 2016-02-20 20:24:14 PST

Created attachment 271873 [details] Patch

Michael Catanzaro

Comment 10 2016-02-21 08:30:49 PST

Probably need to forward-declare KeyboardEvent in Source\WebKit\win\WebView.h.

Darin Adler

Comment 11 2016-02-21 16:31:31 PST

Created attachment 271892 [details] Patch

Andreas Kling

Comment 12 2016-02-21 17:40:08 PST

Comment on attachment 271892 [details] Patch r=me