Bug 154230

Summary: XMLHttpRequest / XMLHttpRequestUpload should inherit XMLHttpRequestEventTarget
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, darin, ggaren, rniwa, sam
Priority: P2 Keywords: WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: https://xhr.spec.whatwg.org/#xmlhttprequesteventtarget
Bug Depends on: 154171    
Bug Blocks:    
Attachments:
Description Flags
WIP Patch
none
Patch none

Description Chris Dumez 2016-02-14 18:33:30 PST
XMLHttpRequest / XMLHttpRequestUpload should inherit XMLHttpRequestEventTarget
Comment 1 Chris Dumez 2016-02-14 19:58:46 PST
Both Firefox and Chrome implement XMLHttpRequestEventTarget and expose it on the global Window object.
Comment 2 Chris Dumez 2016-02-14 21:55:28 PST
Created attachment 271325 [details]
WIP Patch
Comment 3 WebKit Commit Bot 2016-02-14 21:57:47 PST
Attachment 271325 [details] did not pass style-queue:


ERROR: Source/WebCore/xml/XMLHttpRequestEventTarget.h:34:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Chris Dumez 2016-02-14 22:18:57 PST
Created attachment 271326 [details]
Patch
Comment 5 Alex Christensen 2016-02-15 13:08:43 PST
Comment on attachment 271326 [details]
Patch

r=me.  As I've been glancing at the XHR spec, I've wondered why we didn't have this and couldn't think of a good reason other than "nobody's done it yet".
Comment 6 WebKit Commit Bot 2016-02-15 14:03:04 PST
Comment on attachment 271326 [details]
Patch

Clearing flags on attachment: 271326

Committed r196599: <http://trac.webkit.org/changeset/196599>
Comment 7 WebKit Commit Bot 2016-02-15 14:03:07 PST
All reviewed patches have been landed.  Closing bug.