Bug 154219

Summary: [cmake] Consolidated Linux-specific file lists.
Product: WebKit Reporter: Konstantin Tokarev <annulen>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, gyuyoung.kim, lforschler, mcatanzaro, ossy
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Konstantin Tokarev 2016-02-13 11:46:14 PST
Consolidated Linux-specific file lists.
Comment 1 Konstantin Tokarev 2016-02-13 12:35:43 PST
Created attachment 271297 [details]
Patch
Comment 2 Michael Catanzaro 2016-02-13 17:48:05 PST
Comment on attachment 271297 [details]
Patch

I am having second thoughts about putting the files in the top-level Platform directory. That is a really messy directory; it's going to be hard to find them.

Could these files be placed e.g. under platform/linux instead?
Comment 3 Konstantin Tokarev 2016-02-14 01:10:19 PST
1. I think that these files should be put either (a) into one directory, or (b) each of them should be placed where its sources are located. Solution (b) does not work for GStreamer, and it won't work for things like Cairo, so we need to choose one directory.

2. I had the same concerns about clutter in WebCore/platform as you do. In https://bugs.webkit.org/attachment.cgi?id=270993&action=review I've put ImageDecoders.cmake into WebCore root, but Alex disagreed. 

3. platform/linux is acceptable only for Linux.cmake, and certainly not for other components, since they are cross-platform or at least not specific to Linux.
Comment 4 Gyuyoung Kim 2016-02-14 16:49:14 PST
(In reply to comment #3)
> 1. I think that these files should be put either (a) into one directory, or
> (b) each of them should be placed where its sources are located. Solution
> (b) does not work for GStreamer, and it won't work for things like Cairo, so
> we need to choose one directory.
> 
> 2. I had the same concerns about clutter in WebCore/platform as you do. In
> https://bugs.webkit.org/attachment.cgi?id=270993&action=review I've put
> ImageDecoders.cmake into WebCore root, but Alex disagreed. 
> 
> 3. platform/linux is acceptable only for Linux.cmake, and certainly not for
> other components, since they are cross-platform or at least not specific to
> Linux.

I also like to put Linux.cmake into platform/linux in order not to messy webCore/platform directory.
Comment 5 Michael Catanzaro 2016-02-15 07:07:29 PST
Comment on attachment 271297 [details]
Patch

Thinking about this some more, I've come to think alternative solutions are worse; having all the CMake files under platform live in the top-level platform directory seems easiest.
Comment 6 WebKit Commit Bot 2016-02-15 07:53:54 PST
Comment on attachment 271297 [details]
Patch

Clearing flags on attachment: 271297

Committed r196578: <http://trac.webkit.org/changeset/196578>
Comment 7 WebKit Commit Bot 2016-02-15 07:53:57 PST
All reviewed patches have been landed.  Closing bug.