| Summary: | Web Inspector: Sidebars are defaulting to their minimum width, instead of a good width | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Timothy Hatcher <timothy> | ||||||||||
| Component: | Web Inspector | Assignee: | Timothy Hatcher <timothy> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Local Build | ||||||||||||
| Hardware: | All | ||||||||||||
| OS: | All | ||||||||||||
| Attachments: |
|
||||||||||||
Created attachment 271290 [details]
Expected Default Width
Created attachment 271302 [details]
Patch
Comment on attachment 271302 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=271302&action=review > Source/WebInspectorUI/UserInterface/Views/SidebarPanel.js:36 > + this._widthSetting = new WebInspector.Setting(identifier + "-sidebar-panel-width", 300); NIT: Would it be better to put this as something similar to what "WebInspector.Sidebar.AbsoluteMinimumWidth" has? Maybe "WebInspector.Sidebar.InitialWidth = 300;"? Created attachment 271364 [details]
Patch
Ugh, wrong bug webkit-patch! Comment on attachment 271302 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=271302&action=review >> Source/WebInspectorUI/UserInterface/Views/SidebarPanel.js:36 >> + this._widthSetting = new WebInspector.Setting(identifier + "-sidebar-panel-width", 300); > > NIT: Would it be better to put this as something similar to what "WebInspector.Sidebar.AbsoluteMinimumWidth" has? Maybe "WebInspector.Sidebar.InitialWidth = 300;"? Most other settings have the default value inline. If we needed it else where, I would agree. Comment on attachment 271302 [details]
Patch
r=me
Comment on attachment 271302 [details] Patch Clearing flags on attachment: 271302 Committed r196596: <http://trac.webkit.org/changeset/196596> All reviewed patches have been landed. Closing bug. |
Created attachment 271289 [details] Screenshot of the Bug I keep having skinny sidebars, which at at their minimum width. They use to default to a good visual width instead. I suspect this regressed from the changes to calculate the minimum width based on the navigation bars.