Bug 154218

Summary: Web Inspector: Sidebars are defaulting to their minimum width, instead of a good width
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Web InspectorAssignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Screenshot of the Bug
none
Expected Default Width
none
Patch
none
Patch none

Timothy Hatcher
Reported 2016-02-13 10:37:55 PST
Created attachment 271289 [details] Screenshot of the Bug I keep having skinny sidebars, which at at their minimum width. They use to default to a good visual width instead. I suspect this regressed from the changes to calculate the minimum width based on the navigation bars.
Attachments
Screenshot of the Bug (79.73 KB, image/png)
2016-02-13 10:37 PST, Timothy Hatcher 		no flags
Details
Expected Default Width (88.95 KB, image/png)
2016-02-13 10:38 PST, Timothy Hatcher 		no flags
Details
Patch (1.72 KB, patch)
2016-02-13 17:15 PST, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
Patch (3.36 KB, patch)
2016-02-15 13:20 PST, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-02-13 10:38:09 PST
<rdar://problem/24644192>
Timothy Hatcher
Comment 2 2016-02-13 10:38:11 PST
Created attachment 271290 [details] Expected Default Width
Timothy Hatcher
Comment 3 2016-02-13 17:15:36 PST
Created attachment 271302 [details] Patch
Devin Rousso
Comment 4 2016-02-13 17:18:53 PST
Comment on attachment 271302 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=271302&action=review > Source/WebInspectorUI/UserInterface/Views/SidebarPanel.js:36 > + this._widthSetting = new WebInspector.Setting(identifier + "-sidebar-panel-width", 300); NIT: Would it be better to put this as something similar to what "WebInspector.Sidebar.AbsoluteMinimumWidth" has? Maybe "WebInspector.Sidebar.InitialWidth = 300;"?
Timothy Hatcher
Comment 5 2016-02-15 13:20:01 PST
Created attachment 271364 [details] Patch
Timothy Hatcher
Comment 6 2016-02-15 13:20:48 PST
Ugh, wrong bug webkit-patch!
Timothy Hatcher
Comment 7 2016-02-15 13:24:56 PST
Comment on attachment 271302 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=271302&action=review >> Source/WebInspectorUI/UserInterface/Views/SidebarPanel.js:36 >> + this._widthSetting = new WebInspector.Setting(identifier + "-sidebar-panel-width", 300); > > NIT: Would it be better to put this as something similar to what "WebInspector.Sidebar.AbsoluteMinimumWidth" has? Maybe "WebInspector.Sidebar.InitialWidth = 300;"? Most other settings have the default value inline. If we needed it else where, I would agree.
Joseph Pecoraro
Comment 8 2016-02-15 13:25:34 PST
Comment on attachment 271302 [details] Patch r=me
WebKit Commit Bot
Comment 9 2016-02-15 13:30:01 PST
Comment on attachment 271302 [details] Patch Clearing flags on attachment: 271302 Committed r196596: <http://trac.webkit.org/changeset/196596>
WebKit Commit Bot
Comment 10 2016-02-15 13:30:03 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.