Bug 154216

Summary: Web Inspector: CodeMirror styles needs updated for CSS variables
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Web InspectorAssignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: All   
OS: All   
Bug Depends on: 154215    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
With Patch Applied none

Description Timothy Hatcher 2016-02-13 10:21:16 PST 
We need to style the .cm-m-css.cm-varible-2 like a property.
Comment 1 Radar WebKit Bug Importer 2016-02-13 10:21:32 PST 
<rdar://problem/24644146>
Comment 2 Timothy Hatcher 2016-02-13 10:34:02 PST 
Created attachment 271287 [details]
Patch
Comment 3 Timothy Hatcher 2016-02-13 10:34:35 PST 
Created attachment 271288 [details]
With Patch Applied
Comment 4 Joseph Pecoraro 2016-02-15 12:23:46 PST 
Comment on attachment 271287 [details]
Patch

r=me

Should we give them a different color, so they stand out? Just making them look like regular properties seems like a missed opportunity.
Comment 5 Timothy Hatcher 2016-02-15 12:42:49 PST 
(In reply to comment #4)
> Comment on attachment 271287 [details]
> Patch
> 
> r=me
> 
> Should we give them a different color, so they stand out? Just making them
> look like regular properties seems like a missed opportunity.

Maybe we could, but I am not sure what a good color would be.
Comment 6 WebKit Commit Bot 2016-02-15 13:13:23 PST 
Comment on attachment 271287 [details]
Patch

Clearing flags on attachment: 271287

Committed r196592: <http://trac.webkit.org/changeset/196592>
Comment 7 WebKit Commit Bot 2016-02-15 13:13:26 PST 
All reviewed patches have been landed.  Closing bug.