Bug 154216 - Web Inspector: CodeMirror styles needs updated for CSS variables
Summary: Web Inspector: CodeMirror styles needs updated for CSS variables
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on: 154215
Blocks:
  Show dependency tree / graph
 
Reported: 2016-02-13 10:21 PST by Timothy Hatcher
Modified: 2016-02-15 13:13 PST (History)
8 users (show)

See Also:

Attachments
Patch (2.40 KB, patch)
2016-02-13 10:34 PST, Timothy Hatcher 		no flags Details | Formatted Diff | Diff
With Patch Applied (534.37 KB, image/png)
2016-02-13 10:34 PST, Timothy Hatcher 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2016-02-13 10:21:16 PST 
We need to style the .cm-m-css.cm-varible-2 like a property.
Comment 1 Radar WebKit Bug Importer 2016-02-13 10:21:32 PST 
<rdar://problem/24644146>
Comment 2 Timothy Hatcher 2016-02-13 10:34:02 PST 
Created attachment 271287 [details]
Patch
Comment 3 Timothy Hatcher 2016-02-13 10:34:35 PST 
Created attachment 271288 [details]
With Patch Applied
Comment 4 Joseph Pecoraro 2016-02-15 12:23:46 PST 
Comment on attachment 271287 [details]
Patch

r=me

Should we give them a different color, so they stand out? Just making them look like regular properties seems like a missed opportunity.
Comment 5 Timothy Hatcher 2016-02-15 12:42:49 PST 
(In reply to comment #4)
> Comment on attachment 271287 [details]
> Patch
> 
> r=me
> 
> Should we give them a different color, so they stand out? Just making them
> look like regular properties seems like a missed opportunity.

Maybe we could, but I am not sure what a good color would be.
Comment 6 WebKit Commit Bot 2016-02-15 13:13:23 PST 
Comment on attachment 271287 [details]
Patch

Clearing flags on attachment: 271287

Committed r196592: <http://trac.webkit.org/changeset/196592>
Comment 7 WebKit Commit Bot 2016-02-15 13:13:26 PST 
All reviewed patches have been landed.  Closing bug.