Bug 154150

Summary: Web Inspector: SourceCodeTextEditor close() generates removeEventListener warnings
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: DoNotImportToRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Description Joseph Pecoraro 2016-02-11 19:51:16 PST
* SUMMARY
SourceCodeTextEditor close() generates removeEventListener warnings:

Resources/Base/Object.js:97:23: CONSOLE ERROR removeEventListener cannot remove issue-manager-issue-was-added because it doesn't exist.
Resources/Base/Object.js:97:23: CONSOLE ERROR removeEventListener cannot remove source-code-source-map-added because it doesn't exist.

* STEPS TO REPRODUCE
1. Inspect this page
2. Open a bunch of scripts
3. Reload
  => warnings

* NOTES
- We should only removeEventListener if we directly added an event listener. We know that pretty easily here.
Comment 1 Joseph Pecoraro 2016-02-11 19:52:40 PST
Created attachment 271124 [details]
[PATCH] Proposed Fix
Comment 2 WebKit Commit Bot 2016-02-11 21:17:12 PST
Comment on attachment 271124 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 271124

Committed r196464: <http://trac.webkit.org/changeset/196464>
Comment 3 WebKit Commit Bot 2016-02-11 21:17:15 PST
All reviewed patches have been landed.  Closing bug.