Bug 154141
Summary: | Synchronization of SVGMarkerElement DOM methods and orient attribute is broken | ||
---|---|---|---|
Product: | WebKit | Reporter: | Nikos Andronikos <nikos.andronikos> |
Component: | SVG | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED DUPLICATE | ||
Severity: | Normal | CC: | sabouhallawa, zimmermann |
Priority: | P2 | ||
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified |
Nikos Andronikos
Test: https://jsfiddle.net/dodgeyhack/bgLe93sw/
After using the DOM methods:
* setOrientToAuto
* setorientToAngle
And I think after also reading and writing to/from SVGMarkerElement.orientType and SVGMarkerElement.orientAngle.
Then, calling setAttribute with an invalid value causes that value not to be reflected in the attribute as it should.
Minimal JS test:
markerElement.setOrientToAngle(svgElement.createSVGAngle());
shouldNotThrow("markerElement.setAttribute('orient', 'AUTO')");
shouldBeEqualToString("markerElement.getAttribute('orient')", "AUTO");
Fails because getAttribute('orient') returns '0'.
The call stack shows that SetAttributeInternal is called multiple times, which is likely an error:
--Element::setAttribute----------------
name=orient / newValue=AUTO-START-REVERSE
--synchronizeOrientAngle------
shouldSynchronize = 1
--Element::setAttributeInternal----------------
name=orient / newValue=0123456789:;<=>?@ABCDEF... snipped the remaining garbage
--synchronizeOrientType-------
ownerType.m_orientType.value = 2
is angle
--Element::setAttributeInternal----------------
name=orient / newValue=AUTO-START-REVERSE
--parseAttribute-------
name = orient / value = AUTO-START-REVERSE
returns 0
--svgAttributeChanged-------
attrName = orient
--synchronizeOrientAngle------
shouldSynchronize = 1
--Element::setAttributeInternal----------------
name=orient / newValue=0123456789:;<=>?@ABCDEF... snipped the remaining garbage
--synchronizeOrientType-------
ownerType.m_orientType.value = 2
is angle
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Said Abou-Hallawa
This will be fixed by https://bugs.webkit.org/show_bug.cgi?id=196087
*** This bug has been marked as a duplicate of bug 196087 ***