Bug 154130

Summary:

Web Inspector: disambiguate the various identifier and connection types in RemoteInspector

Product:

WebKit

Reporter:

BJ Burg <bburg>

Component:

Web Inspector

Assignee:

BJ Burg <bburg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, graouts, joepeck, keith_miller, mark.lam, mattbaker, msaboff, nvasilyev, saam, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Proposed Fix	joepeck: review+, joepeck: commit-queue-

Description BJ Burg 2016-02-11 14:03:29 PST

It's really confusing.

Comment 1 Radar WebKit Bug Importer 2016-02-11 14:03:50 PST

<rdar://problem/24615659>

Comment 2 BJ Burg 2016-02-11 15:02:05 PST

Created attachment 271096 [details]
Proposed Fix

Comment 3 Joseph Pecoraro 2016-02-12 12:29:58 PST

Comment on attachment 271096 [details]
Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=271096&action=review

r=me

> Source/JavaScriptCore/ChangeLog:67
> +2016-02-11  Brian Burg  <bburg@apple.com>

Double ChangeLog.

> Source/JavaScriptCore/inspector/remote/RemoteInspectorConstants.h:52
> +// COMPATABILITY(iOS 9): The key string is intentionally mismatched to support old relays.
> +#define WIRTargetIdentifierKey                  @"WIRPageIdentifierKey"

Ew, but okay.

Comment 4 BJ Burg 2016-02-12 14:35:46 PST

Committed r196515: <http://trac.webkit.org/changeset/196515>