Bug 154130

Summary: Web Inspector: disambiguate the various identifier and connection types in RemoteInspector
Product: WebKit Reporter: Blaze Burg <bburg>
Component: Web InspectorAssignee: Blaze Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, keith_miller, mark.lam, mattbaker, msaboff, nvasilyev, saam, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed Fix joepeck: review+, joepeck: commit-queue-

Blaze Burg
Reported 2016-02-11 14:03:29 PST
It's really confusing.
Attachments
Proposed Fix (41.23 KB, patch)
2016-02-11 15:02 PST, Blaze Burg 		joepeck: review+
joepeck: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-02-11 14:03:50 PST
<rdar://problem/24615659>
Blaze Burg
Comment 2 2016-02-11 15:02:05 PST
Created attachment 271096 [details] Proposed Fix
Joseph Pecoraro
Comment 3 2016-02-12 12:29:58 PST
Comment on attachment 271096 [details] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=271096&action=review r=me > Source/JavaScriptCore/ChangeLog:67 > +2016-02-11 Brian Burg <bburg@apple.com> Double ChangeLog. > Source/JavaScriptCore/inspector/remote/RemoteInspectorConstants.h:52 > +// COMPATABILITY(iOS 9): The key string is intentionally mismatched to support old relays. > +#define WIRTargetIdentifierKey @"WIRPageIdentifierKey" Ew, but okay.
Blaze Burg
Comment 4 2016-02-12 14:35:46 PST
Committed r196515: <http://trac.webkit.org/changeset/196515>
Note You need to log in before you can comment on or make changes to this bug.