Bug 154130 - Web Inspector: disambiguate the various identifier and connection types in RemoteInspector
Summary: Web Inspector: disambiguate the various identifier and connection types in Re...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Brian Burg
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-02-11 14:03 PST by Brian Burg
Modified: 2016-02-12 14:35 PST (History)
12 users (show)

See Also:


Attachments
Proposed Fix (41.23 KB, patch)
2016-02-11 15:02 PST, Brian Burg
joepeck: review+
joepeck: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Burg 2016-02-11 14:03:29 PST
It's really confusing.
Comment 1 Radar WebKit Bug Importer 2016-02-11 14:03:50 PST
<rdar://problem/24615659>
Comment 2 Brian Burg 2016-02-11 15:02:05 PST
Created attachment 271096 [details]
Proposed Fix
Comment 3 Joseph Pecoraro 2016-02-12 12:29:58 PST
Comment on attachment 271096 [details]
Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=271096&action=review

r=me

> Source/JavaScriptCore/ChangeLog:67
> +2016-02-11  Brian Burg  <bburg@apple.com>

Double ChangeLog.

> Source/JavaScriptCore/inspector/remote/RemoteInspectorConstants.h:52
> +// COMPATABILITY(iOS 9): The key string is intentionally mismatched to support old relays.
> +#define WIRTargetIdentifierKey                  @"WIRPageIdentifierKey"

Ew, but okay.
Comment 4 Brian Burg 2016-02-12 14:35:46 PST
Committed r196515: <http://trac.webkit.org/changeset/196515>