Bug 154118

Summary: WebContent process crashes when performing data detection on content with existing data detector links
Product: WebKit Reporter: Enrica Casucci <enrica>
Component: WebKit2Assignee: Enrica Casucci <enrica>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, thorton
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Description Enrica Casucci 2016-02-11 11:18:40 PST
Loading content that has existing data detector links causes the WebProcess to crash.
The DOM mutation caused by removing the existing links, can shift the range endpoints.

rdar://problem/24511860
Comment 1 Enrica Casucci 2016-02-11 11:24:06 PST
Created attachment 271069 [details]
Patch
Comment 2 Tim Horton 2016-02-11 14:09:13 PST
Comment on attachment 271069 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=271069&action=review

> Source/WebCore/ChangeLog:8
> +

Where's the test!

> Source/WebCore/editing/cocoa/DataDetection.mm:529
> +        // Store the range boundaries as Position, in case the DOM changes if we find
> +        // old data detector link.

This comment has slightly weird grammar towards the end.
Comment 3 Enrica Casucci 2016-02-11 15:04:21 PST
Committed revision 196445.