Bug 154118

Summary: WebContent process crashes when performing data detection on content with existing data detector links
Product: WebKit Reporter: Enrica Casucci <enrica>
Component: WebKit2Assignee: Enrica Casucci <enrica>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, thorton
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Enrica Casucci
Reported 2016-02-11 11:18:40 PST
Loading content that has existing data detector links causes the WebProcess to crash. The DOM mutation caused by removing the existing links, can shift the range endpoints. rdar://problem/24511860
Attachments
Patch (3.79 KB, patch)
2016-02-11 11:24 PST, Enrica Casucci 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Enrica Casucci
Comment 1 2016-02-11 11:24:06 PST
Created attachment 271069 [details] Patch
Tim Horton
Comment 2 2016-02-11 14:09:13 PST
Comment on attachment 271069 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=271069&action=review > Source/WebCore/ChangeLog:8 > + Where's the test! > Source/WebCore/editing/cocoa/DataDetection.mm:529 > + // Store the range boundaries as Position, in case the DOM changes if we find > + // old data detector link. This comment has slightly weird grammar towards the end.
Enrica Casucci
Comment 3 2016-02-11 15:04:21 PST
Committed revision 196445.
Note You need to log in before you can comment on or make changes to this bug.