Bug 154089

Summary: Web Inspector: Add new icon for the Timeline Recording navigation bar item
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Web InspectorAssignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: agomez, bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 154088    
Attachments:
Description Flags
Screenshot
none
Patch
none
[Image] Watch w/ one button
none
[Image] Two-up: original vs. one button none

Timothy Hatcher
Reported 2016-02-10 14:23:17 PST
This icon was still a bitmap after all the others are now vector.
Attachments
Screenshot (26.55 KB, image/png)
2016-02-10 14:24 PST, Timothy Hatcher 		no flags
Details
Patch (13.75 KB, patch)
2016-02-10 14:28 PST, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
[Image] Watch w/ one button (85.86 KB, image/png)
2016-02-10 14:40 PST, Matt Baker 		no flags
Details
[Image] Two-up: original vs. one button (92.80 KB, image/png)
2016-02-10 14:45 PST, Matt Baker 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Timothy Hatcher
Comment 1 2016-02-10 14:24:06 PST
Created attachment 271028 [details] Screenshot
Radar WebKit Bug Importer
Comment 2 2016-02-10 14:24:25 PST
<rdar://problem/24595652>
Timothy Hatcher
Comment 3 2016-02-10 14:28:51 PST
Created attachment 271030 [details] Patch
Matt Baker
Comment 4 2016-02-10 14:39:44 PST
Very nice!
Matt Baker
Comment 5 2016-02-10 14:40:49 PST
Created attachment 271031 [details] [Image] Watch w/ one button Does having three buttons feel too busy at small sizes? Attached is a mockup of the same icon, with just a single button.
Matt Baker
Comment 6 2016-02-10 14:45:27 PST
Created attachment 271032 [details] [Image] Two-up: original vs. one button For comparison
Timothy Hatcher
Comment 7 2016-02-10 14:47:35 PST
The extra buttons is more accurate, since our stopwatch has two arms (a lap arm), which is traditionally controlled by a button, along with reset and start/stop button.
Timothy Hatcher
Comment 8 2016-02-10 14:48:12 PST
It looks fine on retina, and Jon assures me it is good on 1x displays too. (Jon made the icon.)
Matt Baker
Comment 9 2016-02-10 14:51:59 PST
(In reply to comment #8) > It looks fine on retina, and Jon assures me it is good on 1x displays too. > (Jon made the icon.) Ok, sounds good!
Blaze Burg
Comment 10 2016-02-10 16:02:40 PST
Comment on attachment 271030 [details] Patch rs=me
WebKit Commit Bot
Comment 11 2016-02-10 16:52:31 PST
Comment on attachment 271030 [details] Patch Clearing flags on attachment: 271030 Committed r196406: <http://trac.webkit.org/changeset/196406>
WebKit Commit Bot
Comment 12 2016-02-10 16:52:34 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.