Bug 154088

Summary: [GTK] Web Inspector: Add new GTK+ icon for timeline recording stopwatch
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Web InspectorAssignee: Fujii Hironori <Hironori.Fujii>
Status: RESOLVED FIXED    
Severity: Normal CC: agomez, bugs-noreply, buildbot, cgarcia, commit-queue, graouts, Hironori.Fujii, inspector-bugzilla-changes
Priority: P2 Keywords: DoNotImportToRadar
Version: WebKit Local Build   
Hardware: All   
OS: Linux   
Bug Depends on: 154089    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
screenshot of before and after this fix none

Timothy Hatcher
Reported 2016-02-10 14:21:31 PST
Add image for Images/Stopwatch.svg.
Attachments
Patch (9.06 KB, patch)
2017-05-07 20:54 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
screenshot of before and after this fix (13.73 KB, image/png)
2017-05-07 21:08 PDT, Fujii Hironori 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Timothy Hatcher
Comment 1 2016-02-10 14:29:22 PST
Added for Apple platforms in bug 154089.
Fujii Hironori
Comment 2 2017-05-07 20:54:57 PDT
Created attachment 309341 [details] Patch
Fujii Hironori
Comment 3 2017-05-07 21:08:40 PDT
Created attachment 309342 [details] screenshot of before and after this fix
Fujii Hironori
Comment 4 2017-05-07 21:26:45 PDT
This change will break GTK+ incremental build because of removing images. This is the last one I need to remove at the moment. Adding new images won't break the incremental build. Should I do something to avoid the incremental build break? build-webkit checks the timestamp of Source/WebInspectorUI/UserInterface directory. https://trac.webkit.org/browser/webkit/trunk/Tools/Scripts/webkitdirs.pm?rev=215758#L1921 Source/WebInspectorUI/UserInterface/Images/gtk also should be checked? Or more simply, just modifying Source/PlatformGTK.cmake will trigger running cmake.
Carlos Garcia Campos
Comment 5 2017-05-07 23:41:29 PDT
Yes, I triggered clean builds in the bots last time, this is because we use wildcard characters in the makefile. I'm fine with any solution to this.
WebKit Commit Bot
Comment 6 2017-05-08 00:11:52 PDT
Comment on attachment 309341 [details] Patch Clearing flags on attachment: 309341 Committed r216356: <http://trac.webkit.org/changeset/216356>
WebKit Commit Bot
Comment 7 2017-05-08 00:11:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.