Bug 154077

Summary: Web Inspector: RemoteInspector's listings should include whether an AutomationTarget is paired
Product: WebKit Reporter: Blaze Burg <bburg>
Component: Web InspectorAssignee: Blaze Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, keith_miller, mark.lam, mattbaker, msaboff, nvasilyev, saam, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 153934    
Attachments:
Description Flags
Proposed Fix
none
For Landing none

Blaze Burg
Reported 2016-02-10 09:54:47 PST
Splitting from 153934.
Attachments
Proposed Fix (5.84 KB, patch)
2016-02-10 12:35 PST, Blaze Burg 		no flags
DetailsFormatted DiffDiff
For Landing (5.82 KB, patch)
2016-02-11 15:14 PST, Blaze Burg 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-02-10 09:55:04 PST
<rdar://problem/24589133>
Blaze Burg
Comment 2 2016-02-10 12:35:58 PST
Created attachment 271020 [details] Proposed Fix
Joseph Pecoraro
Comment 3 2016-02-11 15:05:05 PST
Comment on attachment 271020 [details] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=271020&action=review > Source/JavaScriptCore/inspector/remote/RemoteInspector.mm:-529 > - if (!target.automationAllowed()) > - return nil; So now, all AutomationTargets are always visible. Okay > Source/JavaScriptCore/inspector/remote/RemoteInspectorConstants.h:85 > +#define WIRDrivableIsPairedKey @"WIRDrivableIsPairedKey" This is the first time something like Drivable appears. Maybe something like WIRAutomationTargetIsPairedKey?
Blaze Burg
Comment 4 2016-02-11 15:14:33 PST
Created attachment 271097 [details] For Landing
WebKit Commit Bot
Comment 5 2016-02-11 16:02:30 PST
Comment on attachment 271097 [details] For Landing Clearing flags on attachment: 271097 Committed r196454: <http://trac.webkit.org/changeset/196454>
WebKit Commit Bot
Comment 6 2016-02-11 16:02:35 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.