Summary: | Web Inspector: RemoteInspector's listings should include whether an AutomationTarget is paired | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | BJ Burg <bburg> | ||||||
Component: | Web Inspector | Assignee: | BJ Burg <bburg> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bburg, commit-queue, graouts, joepeck, keith_miller, mark.lam, mattbaker, msaboff, nvasilyev, saam, timothy, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 153934 | ||||||||
Attachments: |
|
Description
BJ Burg
2016-02-10 09:54:47 PST
Created attachment 271020 [details]
Proposed Fix
Comment on attachment 271020 [details] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=271020&action=review > Source/JavaScriptCore/inspector/remote/RemoteInspector.mm:-529 > - if (!target.automationAllowed()) > - return nil; So now, all AutomationTargets are always visible. Okay > Source/JavaScriptCore/inspector/remote/RemoteInspectorConstants.h:85 > +#define WIRDrivableIsPairedKey @"WIRDrivableIsPairedKey" This is the first time something like Drivable appears. Maybe something like WIRAutomationTargetIsPairedKey? Created attachment 271097 [details]
For Landing
Comment on attachment 271097 [details] For Landing Clearing flags on attachment: 271097 Committed r196454: <http://trac.webkit.org/changeset/196454> All reviewed patches have been landed. Closing bug. |