Bug 154058

Summary: Add internal benchmark tests for CSS mix-blend-modes and filters
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: AnimationsAssignee: Said Abou-Hallawa <sabouhallawa>
Severity: Normal CC: cdumez, commit-queue, dino, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch none

Description Said Abou-Hallawa 2016-02-09 17:52:26 PST
These tests will be based on the bouncing particles css tests but slightly modified to apply the css mix-blend-modes and filters.
Comment 1 Said Abou-Hallawa 2016-02-09 18:01:23 PST
Created attachment 270966 [details]
Comment 2 Jon Lee 2016-02-09 23:36:45 PST
Comment on attachment 270966 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=270966&action=review

Unofficial r=me

> PerformanceTests/Animometer/resources/extensions.js:87
> +    browserPrefix: function ()

No space between function and (). This result is derived and never cached; seems better to rename this to getBrowserPrefix()?

> PerformanceTests/Animometer/resources/extensions.js:93
> +            .match(/-(moz|webkit|ms)-/) || (styles.OLink === '' && ['', 'o'])

This is hard to read. Can we unfold this using if clauses instead?
Comment 3 Said Abou-Hallawa 2016-02-10 12:45:49 PST
Committed r196381: <http://trac.webkit.org/changeset/196381>