Summary: | CSP: Extract helper classes into their own files | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||
Component: | WebCore Misc. | Assignee: | Daniel Bates <dbates> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aestes, bfulgham, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Local Build | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Daniel Bates
2016-02-09 11:11:31 PST
Created attachment 270941 [details]
Patch
Comment on attachment 270941 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=270941&action=review r=me. Please clean up the ChangeLog a bit so it's not so large -- most of that auto-generated information is not useful. > Source/WebCore/ChangeLog:16 > + (WebCore::ContentSecurityPolicy::didReceiveHeader): Ditto. You should shrink this ChangeLog by just indicating: WebCore::ContentSecurityPolicy implementation moved to page/csp/ContentSecurityPolicy.{h, cpp}: WebCore::CSPSource implementation moved to page/csp/ContentSecurityPolicySource.{h, cpp} ... etc ... > Source/WebCore/ChangeLog:35 > + (WebCore::isSourceListNone): Deleted. .... and mention which files these bare functions moved to. (In reply to comment #3) > [...] > > Source/WebCore/ChangeLog:16 > > + (WebCore::ContentSecurityPolicy::didReceiveHeader): Ditto. > > You should shrink this ChangeLog by just indicating: > > WebCore::ContentSecurityPolicy implementation moved to > page/csp/ContentSecurityPolicy.{h, cpp}: > WebCore::CSPSource implementation moved to > page/csp/ContentSecurityPolicySource.{h, cpp} > ... etc ... > Will fix before landing. > > Source/WebCore/ChangeLog:35 > > + (WebCore::isSourceListNone): Deleted. > > .... and mention which files these bare functions moved to. Will fix before landing. Committed r196350: <http://trac.webkit.org/changeset/196350> |