Bug 154020

Summary: B3::foldPathConstants() needs to execute its insertion set
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, mark.lam, msaboff, sbarati
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 150279    
Attachments:
Description Flags
the patch sbarati: review+

Description Filip Pizlo 2016-02-08 16:53:46 PST
Patch forthcoming.
Comment 1 Filip Pizlo 2016-02-08 16:56:03 PST
Created attachment 270895 [details]
the patch
Comment 2 WebKit Commit Bot 2016-02-08 16:57:27 PST
Attachment 270895 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/b3/testb3.cpp:10063:  Consider using CHECK_EQ instead of CHECK(a == b)  [readability/check] [2]
ERROR: Source/JavaScriptCore/b3/testb3.cpp:10064:  Consider using CHECK_EQ instead of CHECK(a == b)  [readability/check] [2]
ERROR: Source/JavaScriptCore/b3/testb3.cpp:10064:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/JavaScriptCore/b3/testb3.cpp:10065:  Consider using CHECK_EQ instead of CHECK(a == b)  [readability/check] [2]
ERROR: Source/JavaScriptCore/b3/testb3.cpp:10065:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 5 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Filip Pizlo 2016-02-08 17:06:47 PST
Landed in http://trac.webkit.org/changeset/196280