Bug 154020 - B3::foldPathConstants() needs to execute its insertion set
Summary: B3::foldPathConstants() needs to execute its insertion set
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 150279
  Show dependency tree / graph
 
Reported: 2016-02-08 16:53 PST by Filip Pizlo
Modified: 2016-02-08 17:06 PST (History)
5 users (show)

See Also:

Attachments
the patch (2.88 KB, patch)
2016-02-08 16:56 PST, Filip Pizlo 		saam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2016-02-08 16:53:46 PST 
Patch forthcoming.
Comment 1 Filip Pizlo 2016-02-08 16:56:03 PST 
Created attachment 270895 [details]
the patch
Comment 2 WebKit Commit Bot 2016-02-08 16:57:27 PST 
Attachment 270895 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/b3/testb3.cpp:10063:  Consider using CHECK_EQ instead of CHECK(a == b)  [readability/check] [2]
ERROR: Source/JavaScriptCore/b3/testb3.cpp:10064:  Consider using CHECK_EQ instead of CHECK(a == b)  [readability/check] [2]
ERROR: Source/JavaScriptCore/b3/testb3.cpp:10064:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/JavaScriptCore/b3/testb3.cpp:10065:  Consider using CHECK_EQ instead of CHECK(a == b)  [readability/check] [2]
ERROR: Source/JavaScriptCore/b3/testb3.cpp:10065:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 5 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Filip Pizlo 2016-02-08 17:06:47 PST 
Landed in http://trac.webkit.org/changeset/196280