Bug 154016

Summary: Web Inspector: Search doesn't seem to find text that is present in multiple places
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2016-02-08 16:09:27 PST
* SUMMARY Search doesn't seem to find text that is present in multiple places. * STEPS TO REPRODUCE 1. Inspect https://www.icloud.com/#photos 2. Global search for “SFNSText” => doesn't seem to find results in packed.css => inspector seems broken (try 1+1 in console) * NOTES It looks like the inspector is sending search requests for the thousands of anonymous, unnamed script evaluations. While potentially useful, I don't think we should be including unnamed scripts when considering search. We should prioritize resources, named scripts, and the DOM.
Attachments
[PATCH] Proposed Fix (2.61 KB, patch)
2016-02-08 16:11 PST, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2016-02-08 16:09:34 PST
<rdar://problem/23391307>
Joseph Pecoraro
Comment 2 2016-02-08 16:11:05 PST
Created attachment 270891 [details] [PATCH] Proposed Fix
Blaze Burg
Comment 3 2016-02-08 17:06:38 PST
Comment on attachment 270891 [details] [PATCH] Proposed Fix r=me
WebKit Commit Bot
Comment 4 2016-02-08 17:55:50 PST
Comment on attachment 270891 [details] [PATCH] Proposed Fix Clearing flags on attachment: 270891 Committed r196285: <http://trac.webkit.org/changeset/196285>
WebKit Commit Bot
Comment 5 2016-02-08 17:55:54 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.