Summary: | Web Inspector: Zooming in on the timeline graph does not increase its time resolution from minutes | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||||||
Component: | Web Inspector | Assignee: | Joseph Pecoraro <joepeck> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Joseph Pecoraro
2016-02-08 15:41:15 PST
Created attachment 270887 [details]
[PATCH] Proposed Fix
Created attachment 270888 [details]
[IMAGE] Sample zooming in on something between 11th and 12th minute of recording
Comment on attachment 270887 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=270887&action=review r=me, small nit. Yay for adding unit tests! Note that they will all fail if we use any other localization file for some reason, so maybe the test should set WebInspector.dontLocalizeUserInterface = true. > Source/WebInspectorUI/UserInterface/Base/Utilities.js:890 > + // Do not got over seconds when in high resolution mode. Nit: 'go over' (In reply to comment #4) > Comment on attachment 270887 [details] > [PATCH] Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=270887&action=review > > r=me, small nit. > > Yay for adding unit tests! Note that they will all fail if we use any other > localization file for some reason, so maybe the test should set > WebInspector.dontLocalizeUserInterface = true. Test.js defines UIString as: WebInspector.UIString = (string) => string; So this shouldn't be a problem in tests. Created attachment 270893 [details]
[PATCH] For Landing
Comment on attachment 270893 [details] [PATCH] For Landing Clearing flags on attachment: 270893 Committed r196284: <http://trac.webkit.org/changeset/196284> |