Bug 154013 - Web Inspector: Zooming in on the timeline graph does not increase its time resolution from minutes
Summary: Web Inspector: Zooming in on the timeline graph does not increase its time re...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-02-08 15:41 PST by Joseph Pecoraro
Modified: 2016-02-09 15:44 PST (History)
8 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (15.75 KB, patch)
2016-02-08 15:44 PST, Joseph Pecoraro
bburg: review+
bburg: commit-queue-
Details | Formatted Diff | Diff
[IMAGE] Sample zooming in on something between 11th and 12th minute of recording (268.66 KB, image/png)
2016-02-08 15:45 PST, Joseph Pecoraro
no flags Details
[PATCH] For Landing (15.74 KB, patch)
2016-02-08 16:51 PST, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-02-08 15:41:15 PST
* SUMMARY
Zooming in on the timeline graph does not increase its time resolution from minutes

* STEPS TO REPRODUCE
1. Inspect this page
2. Start a timeline
3. Wait for 2 minutes
4. Stop recording
5. Zoom in on a second of time between 1 and 2 min
  => Timeline shows "1.8min" for all dividers
Comment 1 Joseph Pecoraro 2016-02-08 15:41:21 PST
<rdar://problem/23844527>
Comment 2 Joseph Pecoraro 2016-02-08 15:44:08 PST
Created attachment 270887 [details]
[PATCH] Proposed Fix
Comment 3 Joseph Pecoraro 2016-02-08 15:45:04 PST
Created attachment 270888 [details]
[IMAGE] Sample zooming in on something between 11th and 12th minute of recording
Comment 4 BJ Burg 2016-02-08 16:04:42 PST
Comment on attachment 270887 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=270887&action=review

r=me, small nit.

Yay for adding unit tests! Note that they will all fail if we use any other localization file for some reason, so maybe the test should set WebInspector.dontLocalizeUserInterface = true.

> Source/WebInspectorUI/UserInterface/Base/Utilities.js:890
> +        // Do not got over seconds when in high resolution mode.

Nit: 'go over'
Comment 5 Joseph Pecoraro 2016-02-08 16:50:50 PST
(In reply to comment #4)
> Comment on attachment 270887 [details]
> [PATCH] Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=270887&action=review
> 
> r=me, small nit.
> 
> Yay for adding unit tests! Note that they will all fail if we use any other
> localization file for some reason, so maybe the test should set
> WebInspector.dontLocalizeUserInterface = true.

Test.js defines UIString as:
WebInspector.UIString = (string) => string;

So this shouldn't be a problem in tests.
Comment 6 Joseph Pecoraro 2016-02-08 16:51:53 PST
Created attachment 270893 [details]
[PATCH] For Landing
Comment 7 WebKit Commit Bot 2016-02-08 17:50:11 PST
Comment on attachment 270893 [details]
[PATCH] For Landing

Clearing flags on attachment: 270893

Committed r196284: <http://trac.webkit.org/changeset/196284>