Bug 154013 – Web Inspector: Zooming in on the timeline graph does not increase its time resolution from minutes

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

* SUMMARY
Zooming in on the timeline graph does not increase its time resolution from minutes

* STEPS TO REPRODUCE
1. Inspect this page
2. Start a timeline
3. Wait for 2 minutes
4. Stop recording
5. Zoom in on a second of time between 1 and 2 min
  => Timeline shows "1.8min" for all dividers

[Joseph Pecoraro]

<rdar://problem/23844527>

[Joseph Pecoraro]

Created attachment 270887 [details]
[PATCH] Proposed Fix

[Joseph Pecoraro]

Created attachment 270888 [details]
[IMAGE] Sample zooming in on something between 11th and 12th minute of recording

[Blaze Burg]

Comment on attachment 270887 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=270887&action=review

r=me, small nit.

Yay for adding unit tests! Note that they will all fail if we use any other localization file for some reason, so maybe the test should set WebInspector.dontLocalizeUserInterface = true.

> Source/WebInspectorUI/UserInterface/Base/Utilities.js:890
> +        // Do not got over seconds when in high resolution mode.

Nit: 'go over'

[Joseph Pecoraro]

(In reply to comment #4)
> Comment on attachment 270887 [details]
> [PATCH] Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=270887&action=review
> 
> r=me, small nit.
> 
> Yay for adding unit tests! Note that they will all fail if we use any other
> localization file for some reason, so maybe the test should set
> WebInspector.dontLocalizeUserInterface = true.

Test.js defines UIString as:
WebInspector.UIString = (string) => string;

So this shouldn't be a problem in tests.

[Joseph Pecoraro]

Created attachment 270893 [details]
[PATCH] For Landing

[WebKit Commit Bot]

Comment on attachment 270893 [details]
[PATCH] For Landing

Clearing flags on attachment: 270893

Committed r196284: <http://trac.webkit.org/changeset/196284>