Bug 153972

Summary:

Make sure that locking code that relies on module boundaries for compiler fences uses NEVER_INLINE

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

Web Template Framework

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cdumez, cmarcelo, commit-queue

Priority:

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
the patch	kling: review+

Filip Pizlo

Reported 2016-02-07 21:28:37 PST

...

Attachments
the patch (4.12 KB, patch) 2016-02-07 21:59 PST, Filip Pizlo	kling: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Filip Pizlo

Comment 1 2016-02-07 21:29:14 PST

One example is the locking code. I don't know what would happen if the locking slow paths were inlined, and the compiler could "see" the locking code at a lock acquisition site.

Filip Pizlo

Comment 2 2016-02-07 21:59:36 PST

Created attachment 270842 [details] the patch

Filip Pizlo

Comment 3 2016-02-08 10:58:27 PST

Landed in http://trac.webkit.org/changeset/196259

Note You need to log in before you can comment on or make changes to this bug.