Bug 153961

Summary: [cmake] Move LLVM detection for LLVMDisassembler to OptionsCommon.cmake
Product: WebKit Reporter: Konstantin Tokarev <annulen>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, commit-queue, lforschler, mcatanzaro, ossy
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Konstantin Tokarev
Reported 2016-02-07 08:20:56 PST
In r196077 ENABLE_FTL_JIT was replaced with USE_LLVM_DISASSEMBLER, however x86_64 requirement is appropriate only for FTL.
Attachments
Patch (1.42 KB, patch)
2016-02-07 08:24 PST, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
Patch (2.73 KB, patch)
2016-02-07 09:49 PST, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Konstantin Tokarev
Comment 1 2016-02-07 08:24:09 PST
Created attachment 270818 [details] Patch
Konstantin Tokarev
Comment 2 2016-02-07 08:25:45 PST
BTW, it may be better to move this check to OptionsCommon, however it would require consensus on required LLVM version.
Michael Catanzaro
Comment 3 2016-02-07 09:07:49 PST
Comment on attachment 270818 [details] Patch I agree, it'd be better to move this from the platform-specific options files to OptionsCommon. We don't care about the required LLVM version since we don't expose USE_LLVM_DISASSEMBLER. I suspect LLVM 3.7 was only required for FTL.
Konstantin Tokarev
Comment 4 2016-02-07 09:49:58 PST
Created attachment 270820 [details] Patch
Konstantin Tokarev
Comment 5 2016-02-07 10:18:10 PST
(In reply to comment #3) > Comment on attachment 270818 [details] > Patch > > I agree, it'd be better to move this from the platform-specific options > files to OptionsCommon. Done.
Michael Catanzaro
Comment 6 2016-02-07 10:39:30 PST
Comment on attachment 270820 [details] Patch Great, thanks.
WebKit Commit Bot
Comment 7 2016-02-07 11:25:34 PST
Comment on attachment 270820 [details] Patch Clearing flags on attachment: 270820 Committed r196241: <http://trac.webkit.org/changeset/196241>
WebKit Commit Bot
Comment 8 2016-02-07 11:25:39 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.