Summary: | FTL must store the call site index before runtime calls, even if it's the tail call slow path | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||
Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, keith_miller, mark.lam, msaboff, saam | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Filip Pizlo
2016-02-06 15:08:14 PST
Created attachment 270807 [details]
the patch
Comment on attachment 270807 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=270807&action=review > Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:5216 > + // with the call site index of our frame. Bad things happen if it's not set. Might be worth adding a test for this if it's not too difficult to write one. Comment on attachment 270807 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=270807&action=review > Source/JavaScriptCore/ChangeLog:9 > + The reasoning is explained in a comment in compileTailCall(). It's probably worth writing out the comment in the change log for posterity. (In reply to comment #2) > Comment on attachment 270807 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=270807&action=review > > > Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:5216 > > + // with the call site index of our frame. Bad things happen if it's not set. > > Might be worth adding a test for this if it's not too difficult to write one. I'll try. :-) (In reply to comment #3) > Comment on attachment 270807 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=270807&action=review > > > Source/JavaScriptCore/ChangeLog:9 > > + The reasoning is explained in a comment in compileTailCall(). > > It's probably worth writing out the comment in the change log for posterity. Will do. Landed in http://trac.webkit.org/changeset/196232 |