Bug 153904

Summary: Web Inspector: Update MemoryTimelineView for new ruler height
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 153034    
Bug Blocks:    
Attachments:
Description Flags
[Patch] Proposed Fix
none
[Image] Updated Memory timeline view
none
[Patch] Proposed Fix
none
[Image] Updated view with decreased padding none

Matt Baker
Reported 2016-02-04 17:45:04 PST
* SUMMARY Update MemoryTimelineView for the new ruler height. The change to ruler styles is part of https://bugs.webkit.org/show_bug.cgi?id=153034.
Attachments
[Patch] Proposed Fix (1.46 KB, patch)
2016-02-04 17:57 PST, Matt Baker 		no flags
DetailsFormatted DiffDiff
[Image] Updated Memory timeline view (432.98 KB, image/png)
2016-02-04 17:59 PST, Matt Baker 		no flags
Details
[Patch] Proposed Fix (1.83 KB, patch)
2016-03-02 21:30 PST, Matt Baker 		no flags
DetailsFormatted DiffDiff
[Image] Updated view with decreased padding (366.26 KB, image/png)
2016-03-02 21:32 PST, Matt Baker 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-02-04 17:45:59 PST
<rdar://problem/24517259>
Matt Baker
Comment 2 2016-02-04 17:57:28 PST
Created attachment 270710 [details] [Patch] Proposed Fix
Matt Baker
Comment 3 2016-02-04 17:59:38 PST
Created attachment 270711 [details] [Image] Updated Memory timeline view
Joseph Pecoraro
Comment 4 2016-02-04 18:48:45 PST
Comment on attachment 270710 [details] [Patch] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=270710&action=review > Source/WebInspectorUI/UserInterface/Views/MemoryTimelineView.css:59 > + padding-top: 2px; I still think a padding-left makes more sense. Previously this would have matched up with a title, but I got rid of that to reduce vertical space.
Timothy Hatcher
Comment 5 2016-03-02 20:02:54 PST
What is the verdict here?
Matt Baker
Comment 6 2016-03-02 21:30:33 PST
Created attachment 272729 [details] [Patch] Proposed Fix
Matt Baker
Comment 7 2016-03-02 21:32:46 PST
Created attachment 272730 [details] [Image] Updated view with decreased padding Not sure how "Categories" is supposed to be left-aligned, so I left it alone.
WebKit Commit Bot
Comment 8 2016-03-02 22:26:51 PST
Comment on attachment 272729 [details] [Patch] Proposed Fix Clearing flags on attachment: 272729 Committed r197493: <http://trac.webkit.org/changeset/197493>
WebKit Commit Bot
Comment 9 2016-03-02 22:26:55 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.