Summary: | Web Inspector: Replace all instances of '%s' with “%s” | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||
Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Devin Rousso
2016-02-04 13:09:05 PST
Created attachment 270759 [details]
Patch
Comment on attachment 270759 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=270759&action=review > Source/WebInspectorUI/ChangeLog:9 > + Switched all WebInspector.UIString() from using '' to ââ. This should be “”. Not ““. (Look at it in a different font.) Comment on attachment 270759 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=270759&action=review >> Source/WebInspectorUI/ChangeLog:9 >> + Switched all WebInspector.UIString() from using '' to ââ. > > This should be “”. Not ““. (Look at it in a different font.) It's the little things that count :) I'll change it now. Created attachment 270762 [details]
Patch
Comment on attachment 270762 [details] Patch Clearing flags on attachment: 270762 Committed r196184: <http://trac.webkit.org/changeset/196184> All reviewed patches have been landed. Closing bug. |