Bug 153891

Summary: Web Inspector: Replace all instances of '%s' with “%s”
Product: WebKit Reporter: Devin Rousso <drousso>
Component: Web InspectorAssignee: Devin Rousso <drousso>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Description Devin Rousso 2016-02-04 13:09:05 PST
These are primarily WebInspector.UIString() instances.
Comment 1 Radar WebKit Bug Importer 2016-02-04 13:09:45 PST
<rdar://problem/24510236>
Comment 2 Devin Rousso 2016-02-05 12:27:31 PST
Created attachment 270759 [details]
Patch
Comment 3 Timothy Hatcher 2016-02-05 12:41:31 PST
Comment on attachment 270759 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=270759&action=review

> Source/WebInspectorUI/ChangeLog:9
> +        Switched all WebInspector.UIString() from using '' to ââ.

This should be “”. Not ““. (Look at it in a different font.)
Comment 4 Devin Rousso 2016-02-05 12:42:37 PST
Comment on attachment 270759 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=270759&action=review

>> Source/WebInspectorUI/ChangeLog:9
>> +        Switched all WebInspector.UIString() from using '' to ââ.
> 
> This should be “”. Not ““. (Look at it in a different font.)

It's the little things that count :) I'll change it now.
Comment 5 Devin Rousso 2016-02-05 12:52:56 PST
Created attachment 270762 [details]
Patch
Comment 6 WebKit Commit Bot 2016-02-05 13:20:57 PST
Comment on attachment 270762 [details]
Patch

Clearing flags on attachment: 270762

Committed r196184: <http://trac.webkit.org/changeset/196184>
Comment 7 WebKit Commit Bot 2016-02-05 13:21:01 PST
All reviewed patches have been landed.  Closing bug.