Summary: | Web Inspector: Give nested inspectors their own process pool | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||||
Component: | Web Inspector | Assignee: | Joseph Pecoraro <joepeck> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | andersca, bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Joseph Pecoraro
2016-02-04 11:45:17 PST
Created attachment 270676 [details]
[PATCH] Proposed Fix
We could create a Vector for pools per level, but I think just 2 pools is fine for now.
Needs a WK2 Owner nod.
Comment on attachment 270676 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=270676&action=review > Source/WebKit2/UIProcess/WebInspectorProxy.cpp:314 > + WebProcessPool* pool = inspectionLevel == 1 ? s_mainInspectorProcessPool : s_nestedInspectorProcessPool; I think this needs to be a reference or a ** to make the later assignment work right. As it stands, I suspect this makes a new pool each time and s_mainInspectorProcessPool / s_nestedInspectorProcessPool are always null. Created attachment 270683 [details]
[PATCH] Proposed Fix
Comment on attachment 270683 [details] [PATCH] Proposed Fix Clearing flags on attachment: 270683 Committed r196142: <http://trac.webkit.org/changeset/196142> All reviewed patches have been landed. Closing bug. |