Bug 153873

Summary:

[Mac] Adopt NSURLSession properties in AVAssetResourceLoader

Product:

WebKit

Reporter:

Jer Noble <jer.noble>

Component:

New Bugs

Assignee:

Jer Noble <jer.noble>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, rniwa

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	eric.carlson: review+
Patch for landing	buildbot: commit-queue-
Archive of layout-test-results from ews104 for mac-yosemite-wk2	none
Archive of layout-test-results from ews103 for mac-yosemite	none
Archive of layout-test-results from ews112 for mac-yosemite	none

Jer Noble

Reported 2016-02-04 10:24:21 PST

[Mac] Adopt NSURLSession properties in AVAssetResourceLoader

Attachments
Patch (15.02 KB, patch) 2016-02-04 10:28 PST, Jer Noble	eric.carlson: review+	Details Formatted Diff Diff
Patch for landing (15.09 KB, patch) 2016-02-04 10:50 PST, Jer Noble	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews104 for mac-yosemite-wk2 (637.78 KB, application/zip) 2016-02-04 11:15 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews103 for mac-yosemite (356.01 KB, application/zip) 2016-02-04 11:28 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews112 for mac-yosemite (324.46 KB, application/zip) 2016-02-04 11:28 PST, Build Bot	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Jer Noble

Comment 1 2016-02-04 10:28:41 PST

Created attachment 270663 [details] Patch

Eric Carlson

Comment 2 2016-02-04 10:43:50 PST

Comment on attachment 270663 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=270663&action=review > Source/WebCore/page/Settings.cpp:599 > + if (gAVFoundationEnabled == enabled) > + return; > + > + gAVFoundationEnabled = enabled; Nit: this check probably isn't worth the extra code it adds.

Jer Noble

Comment 3 2016-02-04 10:50:03 PST

Created attachment 270665 [details] Patch for landing

Build Bot

Comment 4 2016-02-04 11:15:02 PST

Comment on attachment 270665 [details] Patch for landing Attachment 270665 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/782609 Number of test failures exceeded the failure limit.

Build Bot

Comment 5 2016-02-04 11:15:05 PST

Created attachment 270672 [details] Archive of layout-test-results from ews104 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Build Bot

Comment 6 2016-02-04 11:28:17 PST

Comment on attachment 270665 [details] Patch for landing Attachment 270665 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/782660 Number of test failures exceeded the failure limit.

Build Bot

Comment 7 2016-02-04 11:28:20 PST

Created attachment 270673 [details] Archive of layout-test-results from ews103 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 8 2016-02-04 11:28:56 PST

Comment on attachment 270665 [details] Patch for landing Attachment 270665 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/782647 Number of test failures exceeded the failure limit.

Build Bot

Comment 9 2016-02-04 11:28:58 PST

Created attachment 270674 [details] Archive of layout-test-results from ews112 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-yosemite Platform: Mac OS X 10.10.5

Jer Noble

Comment 10 2016-02-09 12:56:53 PST

Committed r196328: <http://trac.webkit.org/changeset/196328>

Note You need to log in before you can comment on or make changes to this bug.